Skip to content

Commit 352cd76

Browse files
committed
HADOOP-10754. Reenable several HA ZooKeeper-related tests on Windows. Contributed by Chris Nauroth.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1605924 13f79535-47bb-0310-9956-ffa450edef68
1 parent 6f36145 commit 352cd76

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed

hadoop-common-project/hadoop-common/CHANGES.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -477,6 +477,9 @@ Release 2.5.0 - UNRELEASED
477477
HADOOP-10674. Improve PureJavaCrc32 performance and use java.util.zip.CRC32
478478
for Java 7 and above. (szetszwo)
479479

480+
HADOOP-10754. Reenable several HA ZooKeeper-related tests on Windows.
481+
(cnauroth)
482+
480483
OPTIMIZATIONS
481484

482485
BUG FIXES

hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElectorRealZK.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
import static org.junit.Assert.assertFalse;
2222
import static org.junit.Assert.assertTrue;
23-
import static org.junit.Assume.assumeTrue;
2423

2524
import java.util.Collections;
2625
import java.util.UUID;
@@ -30,7 +29,6 @@
3029
import org.apache.hadoop.ha.ActiveStandbyElector.ActiveStandbyElectorCallback;
3130
import org.apache.hadoop.ha.ActiveStandbyElector.State;
3231
import org.apache.hadoop.util.ZKUtil.ZKAuthInfo;
33-
import org.apache.hadoop.util.Shell;
3432
import org.apache.log4j.Level;
3533
import org.apache.zookeeper.ZooDefs.Ids;
3634
import org.apache.zookeeper.server.ZooKeeperServer;
@@ -62,8 +60,6 @@ public class TestActiveStandbyElectorRealZK extends ClientBaseWithFixes {
6260

6361
@Override
6462
public void setUp() throws Exception {
65-
// skip tests on Windows until after resolution of ZooKeeper client bug
66-
assumeTrue(!Shell.WINDOWS);
6763
super.setUp();
6864

6965
zkServer = getServer(serverFactory);

hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverControllerStress.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,11 @@
1717
*/
1818
package org.apache.hadoop.ha;
1919

20-
import static org.junit.Assume.assumeTrue;
21-
2220
import java.util.Random;
2321

2422

2523
import org.apache.hadoop.conf.Configuration;
2624
import org.apache.hadoop.fs.CommonConfigurationKeys;
27-
import org.apache.hadoop.util.Shell;
2825
import org.apache.hadoop.util.Time;
2926
import org.junit.After;
3027
import org.junit.Before;
@@ -49,8 +46,6 @@ public class TestZKFailoverControllerStress extends ClientBaseWithFixes {
4946

5047
@Before
5148
public void setupConfAndServices() throws Exception {
52-
// skip tests on Windows until after resolution of ZooKeeper client bug
53-
assumeTrue(!Shell.WINDOWS);
5449
conf = new Configuration();
5550
conf.set(ZKFailoverController.ZK_QUORUM_KEY, hostPort);
5651
this.cluster = new MiniZKFCCluster(conf, getServer(serverFactory));

0 commit comments

Comments
 (0)