Bug#31180526 CHANGING TABLESPACE BY INPLACE ALTER CORRUPTION

Changing the tablespace of a table using an inplace alter table fails to
update NDB dictionary with the new tablespace name and tablespace id.
Even if an attempt to update the NDB dictionary was made, it would not
properly move over data to the new tablespace.

Fix by not allowing TABLESPACE to be changed by inplace alter table
until NDB supports changing tablespace online.

Restrict both cases:
1) Assigning a table (which does not already has one) to a tablespace
2) Changing the tablespace of a table

Add printout of tablespace id and name to make them visible in
for example ndb_desc.

Change-Id: I78c81cb4b5fc460d1f75560c053c3d21a5a2fbc9

Author: blaudden

mysql-test/suite/ndb/include/ndb_desc_print.inc

@@ -18,7 +18,8 @@ replace_regex /Version: [0-9]*/Version: Any/
               /Length of frm data: [0-9]*/Length of frm data: XXX/
               /IndexTable [0-9]*/IndexTable XX/
               /^([0-9][0-9]*) [0-9 	]*/\1 .../
-              /Table id: [0-9]*/Table id: XXX/;
+              /Table id: [0-9]*/Table id: XXX/
+              /Tablespace id: [0-9]*/Tablespace id: XX/;
 --exec $ndb_desc_cmd
 
 # Reset argument variable in order to detect missing assignment

mysql-test/suite/ndb/r/ndb_add_partition.result

@@ -198,6 +198,8 @@ ExtraRowAuthorBits: 0
 TableStatus: Retrieved
 Table options: readbackup
 HashMap: DEFAULT-HASHMAP-3840-2
+Tablespace id: XX
+Tablespace: ts1
 -- Attributes --
 a Unsigned PRIMARY KEY DISTRIBUTION KEY AT=FIXED ST=MEMORY
 b Unsigned PRIMARY KEY AT=FIXED ST=MEMORY
@@ -916,6 +918,8 @@ ExtraRowAuthorBits: 0
 TableStatus: Retrieved
 Table options: readbackup
 HashMap: DEFAULT-HASHMAP-3840-2
+Tablespace id: XX
+Tablespace: ts1
 -- Attributes --
 a Unsigned PRIMARY KEY DISTRIBUTION KEY AT=FIXED ST=MEMORY
 b Unsigned PRIMARY KEY AT=FIXED ST=MEMORY
@@ -1388,6 +1392,8 @@ ExtraRowAuthorBits: 0
 TableStatus: Retrieved
 Table options: readbackup
 HashMap: DEFAULT-HASHMAP-3840-6
+Tablespace id: XX
+Tablespace: ts1
 -- Attributes --
 a Unsigned PRIMARY KEY DISTRIBUTION KEY AT=FIXED ST=MEMORY
 b Unsigned PRIMARY KEY AT=FIXED ST=MEMORY
@@ -2052,6 +2058,8 @@ ExtraRowAuthorBits: 0
 TableStatus: Retrieved
 Table options: readbackup
 HashMap: HASHMAP-3840-6-7
+Tablespace id: XX
+Tablespace: ts1
 -- Attributes --
 a Unsigned PRIMARY KEY DISTRIBUTION KEY AT=FIXED ST=MEMORY
 b Unsigned PRIMARY KEY AT=FIXED ST=MEMORY

mysql-test/suite/ndb/r/ndb_storage.result

@@ -9,11 +9,11 @@ ADD DATAFILE 'ts1_datafile.dat'
 INITIAL_SIZE 10M
 ENGINE ndb;
 CREATE TABLE t5 (a int PRIMARY KEY, t5b int, t5c int)
-ENGINE ndb;
+ENGINE ndb TABLESPACE ts1;
 INSERT INTO t5 VALUES (1, 1, 1);
-ALTER TABLE t5 ALGORITHM=inplace, STORAGE disk TABLESPACE ts1;
+ALTER TABLE t5 ALGORITHM=inplace, STORAGE disk;
 ERROR 0A000: ALGORITHM=INPLACE is not supported. Reason: Column storage media is changed due to change in table storage media. Try ALGORITHM=COPY.
-ALTER TABLE t5 STORAGE DISK TABLESPACE ts1;
+ALTER TABLE t5 STORAGE DISK;
 ALTER TABLESPACE ts1
 DROP DATAFILE 'ts1_datafile.dat';
 ERROR HY000: Failed to alter: DROP DATAFILE FAILED

mysql-test/suite/ndb/t/ndb_storage.test

@@ -31,14 +31,14 @@ CREATE TABLESPACE ts1
 ##  verify whether the copy algorithm is used.
 
 CREATE TABLE t5 (a int PRIMARY KEY, t5b int, t5c int)
-   ENGINE ndb;
+   ENGINE ndb TABLESPACE ts1;
 INSERT INTO t5 VALUES (1, 1, 1);
 
 # Moving implicit memory columns to disk will be
 # an automatic copy alter (no need to specify alg=copy)
 --error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
-ALTER TABLE t5 ALGORITHM=inplace, STORAGE disk TABLESPACE ts1;
-ALTER TABLE t5 STORAGE DISK TABLESPACE ts1;
+ALTER TABLE t5 ALGORITHM=inplace, STORAGE disk;
+ALTER TABLE t5 STORAGE DISK;
 
 #Check if the disk data is on disk
 --error ER_ALTER_FILEGROUP_FAILED

mysql-test/suite/ndb_ddl/alter_inplace_tablespace.result

@@ -0,0 +1,36 @@
+CREATE LOGFILE GROUP lg1
+ADD UNDOFILE 'lg1_undofile.dat'
+  INITIAL_SIZE 1M
+UNDO_BUFFER_SIZE = 1M
+ENGINE NDB;
+CREATE TABLESPACE ts1
+ADD DATAFILE 'ts1_datafile.dat'
+  USE LOGFILE GROUP lg1
+INITIAL_SIZE 16M
+ENGINE NDB;
+CREATE TABLESPACE ts2
+ADD DATAFILE 'ts2_datafile.dat'
+  USE LOGFILE GROUP lg1
+INITIAL_SIZE 16M
+ENGINE NDB;
+CREATE TABLE t1 (
+a int PRIMARY KEY,
+b int
+) ENGINE = NDB;
+ALTER TABLE t1 ALGORITHM=inplace, TABLESPACE ts1;
+ERROR 0A000: ALGORITHM=INPLACE is not supported. Reason: Adding or changing TABLESPACE. Try ALGORITHM=COPY.
+ALTER TABLE t1 TABLESPACE ts1;
+ALTER TABLE t1 ALGORITHM=inplace, TABLESPACE=ts2;
+ERROR 0A000: ALGORITHM=INPLACE is not supported. Reason: Adding or changing TABLESPACE. Try ALGORITHM=COPY.
+ALTER TABLE t1 ALGORITHM=inplace, TABLESPACE=ts1;
+ERROR 0A000: ALGORITHM=INPLACE is not supported. Reason: Adding or changing TABLESPACE. Try ALGORITHM=COPY.
+ALTER TABLE t1 TABLESPACE ts2;
+DROP TABLE t1;
+ALTER TABLESPACE ts1
+DROP DATAFILE 'ts1_datafile.dat';
+DROP TABLESPACE ts1;
+ALTER TABLESPACE ts2
+DROP DATAFILE 'ts2_datafile.dat';
+DROP TABLESPACE ts2;
+DROP LOGFILE GROUP lg1
+ENGINE NDB;

mysql-test/suite/ndb_ddl/alter_inplace_tablespace.test

@@ -0,0 +1,59 @@
+--source include/have_ndb.inc
+
+# Test that inplace alter table does not support adding or changing tablespace
+# for a table
+#
+
+CREATE LOGFILE GROUP lg1
+  ADD UNDOFILE 'lg1_undofile.dat'
+  INITIAL_SIZE 1M
+  UNDO_BUFFER_SIZE = 1M
+  ENGINE NDB;
+
+CREATE TABLESPACE ts1
+  ADD DATAFILE 'ts1_datafile.dat'
+  USE LOGFILE GROUP lg1
+  INITIAL_SIZE 16M
+  ENGINE NDB;
+
+CREATE TABLESPACE ts2
+  ADD DATAFILE 'ts2_datafile.dat'
+  USE LOGFILE GROUP lg1
+  INITIAL_SIZE 16M
+  ENGINE NDB;
+
+CREATE TABLE t1 (
+  a int PRIMARY KEY,
+  b int
+) ENGINE = NDB;
+
+# Adding tablespace not supported by inplace alter
+# i.e 'no tablespace' -> 't1'
+--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
+ALTER TABLE t1 ALGORITHM=inplace, TABLESPACE ts1;
+
+# Add tablespace to t1 with copying alter
+ALTER TABLE t1 TABLESPACE ts1;
+
+# Changing tablespace not supported by inplace alter
+# ie. 'ts1' -> 'ts2'
+--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
+ALTER TABLE t1 ALGORITHM=inplace, TABLESPACE=ts2;
+
+# Neither changing to same name is supported by inplace alter
+# ie. 'ts1' -> 'ts1'
+--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
+ALTER TABLE t1 ALGORITHM=inplace, TABLESPACE=ts1;
+
+# Changing tablespace to t2 with copying alter
+ALTER TABLE t1 TABLESPACE ts2;
+
+DROP TABLE t1;
+ALTER TABLESPACE ts1
+  DROP DATAFILE 'ts1_datafile.dat';
+DROP TABLESPACE ts1;
+ALTER TABLESPACE ts2
+  DROP DATAFILE 'ts2_datafile.dat';
+DROP TABLESPACE ts2;
+DROP LOGFILE GROUP lg1
+  ENGINE NDB;

storage/ndb/plugin/ha_ndbcluster.cc

@@ -15092,7 +15092,7 @@ enum_alter_inplace_result ha_ndbcluster::supported_inplace_column_change(
 
   HA_CREATE_INFO *create_info = ha_alter_info->create_info;
 
-  bool is_table_storage_changed = table_storage_changed(create_info);
+  const bool is_table_storage_changed = table_storage_changed(create_info);
 
   DBUG_PRINT("info", ("Checking if supported column change for field %s",
                       old_field->field_name));
@@ -15260,6 +15260,12 @@ enum_alter_inplace_result ha_ndbcluster::check_inplace_alter_supported(
       DBUG_PRINT("info", ("The COMMENT string changed"));
       comment_changed = true;
     }
+
+    if (create_info->used_fields & HA_CREATE_USED_TABLESPACE) {
+      // Changing TABLESPACE is not supported by inplace alter
+      return inplace_unsupported(ha_alter_info,
+                                 "Adding or changing TABLESPACE");
+    }
   }
 
   if (alter_flags & Alter_inplace_info::ALTER_TABLE_REORG) {

storage/ndb/src/ndbapi/NdbDictionary.cpp

@@ -1,5 +1,5 @@
 /*
-   Copyright (c) 2003, 2019, Oracle and/or its affiliates. All rights reserved.
+   Copyright (c) 2003, 2020, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License, version 2.0,
@@ -724,26 +724,6 @@ NdbDictionary::Table::setSingleUserMode(enum NdbDictionary::Table::SingleUserMod
   m_impl.m_single_user_mode = (Uint8)mode;
 }
 
-#if 0
-int
-NdbDictionary::Table::setTablespaceNames(const void *data, Uint32 len)
-{
-  return m_impl.setTablespaceNames(data, len);
-}
-
-const void*
-NdbDictionary::Table::getTablespaceNames()
-{
-  return m_impl.getTablespaceNames();
-}
-
-Uint32
-NdbDictionary::Table::getTablespaceNamesLen() const
-{
-  return m_impl.getTablespaceNamesLen();
-}
-#endif
-
 void
 NdbDictionary::Table::setLinearFlag(Uint32 flag)
 {
@@ -4596,6 +4576,21 @@ void NdbDictionary::Dictionary::print(NdbOut& ndbout, NdbDictionary::Table const
     ndbout << "HashMap: " << hashmap.getName() << endl;
   }
 
+  Uint32 tablespace_id;
+  if (tab.getTablespace(&tablespace_id))
+  {
+    ndbout << "Tablespace id: " << tablespace_id << endl;
+
+    // Look up tablespace by id and show the name
+    // NOTE! The tablespace name of a table object which
+    // has been fetched from NDB is not assigned any value.
+    const NdbDictionary::Tablespace ts = getTablespace(tablespace_id);
+    if (getNdbError().code == 0)
+    {
+      ndbout << "Tablespace: " << ts.getName() << endl;
+    }
+  }
+
   ndbout << "-- Attributes --" << endl;
   for (int col = 0; col < tab.getNoOfColumns() ; col++)
   {