Bug#29801100 DECOUPLE NDB_RESTORE FROM NDBCLUSTER PLUGIN TABLE NAMES

Follow up patch to fix compiler warning:

  ndb_util_table.cc:52:50: warning: pass by value and use std::move
[modernize-pass-by-value]
  Ndb_util_table::Ndb_util_table(Thd_ndb* thd_ndb, const std::string
&db_name,
                                                 ^~~~~~~~~~~~~~~~~~~
                                                 std::string

Change-Id: I400bb1e9f36b35c072155d3487dd69b3e110f5f1

Author: blaudden

sql/ndb_util_table.cc

@@ -25,6 +25,8 @@
 // Implements the interface defined in
 #include "sql/ndb_util_table.h"
 
+#include <utility>
+
 #include "my_base.h"
 #include "my_byteorder.h" // uint2korr
 #include "mysql_version.h"
@@ -49,12 +51,12 @@ class Db_name_guard {
   }
 };
 
-Ndb_util_table::Ndb_util_table(Thd_ndb* thd_ndb, const std::string &db_name,
-                               const std::string &table_name, bool hidden)
+Ndb_util_table::Ndb_util_table(Thd_ndb* thd_ndb, std::string db_name,
+                               std::string table_name, bool hidden)
     : m_thd_ndb(thd_ndb),
       m_table_guard(thd_ndb->ndb->getDictionary()),
-      m_db_name(db_name),
-      m_table_name(table_name),
+      m_db_name(std::move(db_name)),
+      m_table_name(std::move(table_name)),
       m_hidden(hidden) {}
 
 Ndb_util_table::~Ndb_util_table() {}

sql/ndb_util_table.h

@@ -33,11 +33,12 @@
 #include "storage/ndb/include/ndbapi/NdbDictionary.hpp"
 
 class NdbRecAttr;
+class Thd_ndb;
 
 // Base class used for working with tables created in NDB by the
 // ndbcluster plugin
 class Ndb_util_table {
-  class Thd_ndb* const m_thd_ndb;
+  Thd_ndb* const m_thd_ndb;
   Ndb_table_guard m_table_guard;
   const std::string m_db_name;
   const std::string m_table_name;
@@ -54,8 +55,8 @@ class Ndb_util_table {
   void push_warning(const char* fmt, ...) const
       MY_ATTRIBUTE((format(printf, 2, 3)));
 
-  Ndb_util_table(class Thd_ndb*, const std::string& db_name,
-                 const std::string& table_name, bool hidden);
+  Ndb_util_table(Thd_ndb*, std::string  db_name,
+                 std::string  table_name, bool hidden);
   ~Ndb_util_table();
 
   bool check_column_exist(const char* name) const;