Skip to content

Commit faa8b98

Browse files
authored
Merge pull request #17 from ymkmoon/style/constants
style: Constants 클래스명 변경
2 parents 1b11f44 + 07f2bad commit faa8b98

File tree

5 files changed

+21
-25
lines changed

5 files changed

+21
-25
lines changed

src/main/java/com/example/template/auth/AuthController.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import com.example.template.common.ApiResponse;
1313
import com.example.template.common.dto.AuthDto;
1414
import com.example.template.common.dto.AuthDto.SignInResponse;
15-
import com.example.template.constants.CommonConstants;
15+
import com.example.template.constants.AuthConstants;
1616
import com.example.template.constants.ResponseCode;
1717
import com.example.template.security.TokenProvider;
1818

@@ -86,9 +86,8 @@ public ResponseEntity<ApiResponse<Object>> refreshToken(@RequestBody @Valid Auth
8686
if(!registRefreshToken) {
8787
return ApiResponse.error(ResponseCode.INVALUD_REFRESH_TOKEN);
8888
}
89-
89+
String uuid = tokenProvider.getUuidFromToken(refreshRequest.getRefreshToken(), AuthConstants.REFRESH_TOKEN.getTitle());
9090
String accessToken = tokenProvider.validateRefreshToken(refreshRequest.getRefreshToken());
91-
String uuid = tokenProvider.getUuidFromToken(accessToken, CommonConstants.ACCESS_TOKEN.getTitle());
9291
authService.saveAccessToken(uuid, accessToken);
9392

9493
AuthDto.SignInResponse response = AuthDto.SignInResponse.builder()

src/main/java/com/example/template/auth/AuthServiceImpl.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
import com.example.template.admin.AdminRepository;
1515
import com.example.template.common.dto.AuthDto;
16-
import com.example.template.constants.CommonConstants;
16+
import com.example.template.constants.AuthConstants;
1717
import com.example.template.constants.ResponseCode;
1818
import com.example.template.exception.BusinessException;
1919
import com.example.template.model.entity.AdminEntity;
@@ -73,7 +73,7 @@ public UserDetails loadUserByUuid(String uuid) {
7373

7474
@Override
7575
public AuthDto.RefreshResponse saveRefreshToken(AuthDto.SignInResponse token) {
76-
String uuid = tokenProvider.getUuidFromToken(token.getRefreshToken(), CommonConstants.REFRESH_TOKEN.getTitle());
76+
String uuid = tokenProvider.getUuidFromToken(token.getRefreshToken(), AuthConstants.REFRESH_TOKEN.getTitle());
7777

7878
AdminEntity admin = adminRepository.findById(uuid)
7979
.orElseThrow(() -> new UsernameNotFoundException(ResponseCode.USER_NAME_NOT_FOUND.getDetail()));
@@ -105,7 +105,7 @@ public AuthDto.RefreshResponse saveRefreshToken(AuthDto.SignInResponse token) {
105105
@Override
106106
public boolean validateRegistRefreshToken(AuthDto.RefreshRequest refreshRequest) {
107107
String refreshToken = refreshRequest.getRefreshToken();
108-
String uuid = tokenProvider.getUuidFromToken(refreshToken, CommonConstants.REFRESH_TOKEN.getTitle());
108+
String uuid = tokenProvider.getUuidFromToken(refreshToken, AuthConstants.REFRESH_TOKEN.getTitle());
109109

110110
AdminEntity admin = adminRepository.findById(uuid)
111111
.orElseThrow(() -> new UsernameNotFoundException(ResponseCode.USER_NAME_NOT_FOUND.getDetail()));
@@ -117,7 +117,7 @@ public boolean validateRegistRefreshToken(AuthDto.RefreshRequest refreshRequest)
117117

118118
@Override
119119
public void saveAccessToken(String username, String accessToken) {
120-
long accessTokenExpireIn = tokenProvider.getExpiration(accessToken, CommonConstants.ACCESS_TOKEN.getTitle());
120+
long accessTokenExpireIn = tokenProvider.getExpiration(accessToken, AuthConstants.ACCESS_TOKEN.getTitle());
121121

122122
// 기존 토큰 삭제
123123
if (redisService.hasAccessToken(username)) {

src/main/java/com/example/template/constants/CommonConstants.java renamed to src/main/java/com/example/template/constants/AuthConstants.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,13 @@
1313
*/
1414
@Getter
1515
@AllArgsConstructor
16-
public enum CommonConstants {
16+
public enum AuthConstants {
1717

1818
ACCESS_TOKEN("AccessToken"),
1919
REFRESH_TOKEN("RefreshToken"),
2020
ADMIN_UUID("uuid"),
2121
ADMIN_ROLE("role"),
22-
EMPTY("Empty"),
23-
START_AT("startAt"),
24-
END_AT("endAt")
22+
2523
;
2624

2725
private final String title;

src/main/java/com/example/template/filter/JwtRequestFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import org.springframework.web.util.ContentCachingRequestWrapper;
1313

1414
import com.example.template.auth.AuthService;
15-
import com.example.template.constants.CommonConstants;
15+
import com.example.template.constants.AuthConstants;
1616
import com.example.template.constants.ResponseCode;
1717
import com.example.template.constants.SecurityConstants;
1818
import com.example.template.error.FailResponse;
@@ -53,7 +53,7 @@ protected void doFilterInternal(HttpServletRequest request, HttpServletResponse
5353
String accessToken = getAccessTokenFromRequestHeader(wrappedRequest);
5454

5555
try {
56-
String uuid = tokenProvider.getUuidFromToken(accessToken, CommonConstants.ACCESS_TOKEN.getTitle());
56+
String uuid = tokenProvider.getUuidFromToken(accessToken, AuthConstants.ACCESS_TOKEN.getTitle());
5757
String storedToken = redisService.getAccessToken(uuid);
5858

5959
// Redis에 저장된 토큰과 비교

src/main/java/com/example/template/security/TokenProvider.java

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
import com.example.template.common.dto.AuthDto;
1313
import com.example.template.config.JwtConfig;
14-
import com.example.template.constants.CommonConstants;
14+
import com.example.template.constants.AuthConstants;
1515
import com.example.template.constants.ResponseCode;
1616
import com.example.template.exception.BusinessException;
1717

@@ -39,7 +39,7 @@ public class TokenProvider {
3939
* @return 토큰을 디코딩 하여 조회 한 관리자의 uuid
4040
*/
4141
public String getUuidFromToken(String token, String tokenType) {
42-
return getCustomClaimFromToken(token, CommonConstants.ADMIN_UUID.getTitle(), tokenType);
42+
return getCustomClaimFromToken(token, AuthConstants.ADMIN_UUID.getTitle(), tokenType);
4343
}
4444

4545

@@ -94,14 +94,13 @@ private boolean isTokenExpired(String token, String tokenType) {
9494
public AuthDto.SignInResponse generateToken(Authentication authentication) {
9595

9696
Map<String, Object> claims = new HashMap<>();
97-
claims.put(CommonConstants.ADMIN_UUID.getTitle(), authentication.getName());
97+
claims.put(AuthConstants.ADMIN_UUID.getTitle(), authentication.getName());
9898

9999
CustomUserDetails userDetails = (CustomUserDetails) authentication.getPrincipal();
100-
claims.put("role", userDetails.getAuthorities().iterator().next().getAuthority()); // role
101-
// claims.put("email", userDetails.getEmail()); // email
100+
claims.put(AuthConstants.ADMIN_ROLE.getTitle(), userDetails.getAuthorities().iterator().next().getAuthority()); // role
102101

103-
String accessToken = doGenerateToken(claims, CommonConstants.ACCESS_TOKEN.getTitle());
104-
String refreshToken = doGenerateToken(claims, CommonConstants.REFRESH_TOKEN.getTitle());
102+
String accessToken = doGenerateToken(claims, AuthConstants.ACCESS_TOKEN.getTitle());
103+
String refreshToken = doGenerateToken(claims, AuthConstants.REFRESH_TOKEN.getTitle());
105104

106105
return AuthDto.SignInResponse.builder()
107106
.accessToken(accessToken)
@@ -131,18 +130,18 @@ private String doGenerateToken(Map<String, Object> claims, String tokenType) {
131130
* @return 토큰 유효성 검증
132131
*/
133132
public boolean validateAccessToken(String accessToken, UserDetails userDetails) {
134-
final String uuid = getUuidFromToken(accessToken, CommonConstants.ACCESS_TOKEN.getTitle());
135-
return (uuid.equals(userDetails.getUsername())) && !isTokenExpired(accessToken, CommonConstants.ACCESS_TOKEN.getTitle());
133+
final String uuid = getUuidFromToken(accessToken, AuthConstants.ACCESS_TOKEN.getTitle());
134+
return (uuid.equals(userDetails.getUsername())) && !isTokenExpired(accessToken, AuthConstants.ACCESS_TOKEN.getTitle());
136135
}
137136

138137
/**
139138
* @param refreshToken
140139
* @return 토큰 유효성 검증
141140
*/
142141
public String validateRefreshToken(String refreshToken) {
143-
if (!isTokenExpired(refreshToken, CommonConstants.REFRESH_TOKEN.getTitle())) {
144-
final Claims claims = getAllClaimsFromToken(refreshToken, CommonConstants.REFRESH_TOKEN.getTitle());
145-
return doGenerateToken(claims, CommonConstants.ACCESS_TOKEN.getTitle());
142+
if (!isTokenExpired(refreshToken, AuthConstants.REFRESH_TOKEN.getTitle())) {
143+
final Claims claims = getAllClaimsFromToken(refreshToken, AuthConstants.REFRESH_TOKEN.getTitle());
144+
return doGenerateToken(claims, AuthConstants.ACCESS_TOKEN.getTitle());
146145
}
147146
throw new BusinessException(ResponseCode.TOKEN_EXPIRED);
148147
}

0 commit comments

Comments
 (0)