Bug #30444982 : BUG #30427675 WL#8426 : "TESTDICT -N BUG13416603 I2" FAILS

Problem
-------
Function do_action() assumes that the nodelist containing the index stat nodes
is ordered but the nodelist is not always ordered in the same way in all the nodes.
The order could change if one or more data nodes restart.
Hence, do_action() wrongly ignores an index stat update request in this case.
Therefore, all the nodes ignore the request resulting in no update made to the
index statistics tables.

Solution
--------
-> Make sure that the node list is ordered in the same way in all the nodes.

Approved-by: Mauritz Sundell <[email protected]>

Author: dssanju

storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp

@@ -14800,11 +14800,31 @@ Dbdict::set_index_stat_frag(Signal* signal, TableRecordPtr indexPtr)
 
   indexPtr.p->indexStatFragId = fragId;
   bzero(indexPtr.p->indexStatNodes, sizeof(indexPtr.p->indexStatNodes));
+
+  /**
+   * Use the bitmask for sorting, the order of node IDs in frag_data is
+   * not the same in all the data nodes.
+   */
+  NdbNodeBitmask sortedNodes;
   for (Uint32 i = 0; i < noOfReplicas; i++)
   {
-    Uint32 idx = fragIndex + 1 + (nodeIndex + i) % noOfReplicas;
-    indexPtr.p->indexStatNodes[i] = frag_data[idx];
+    Uint32 idx = fragIndex + 1 + i;
+    sortedNodes.set(frag_data[idx]);
+  }
+
+  // clear list
+  memset(indexPtr.p->indexStatNodes, 0, sizeof(indexPtr.p->indexStatNodes) / sizeof(Uint16));
+
+  // rotate the sorted nodes into the list
+  for (Uint32 nodeId = sortedNodes.find_first(), i = 0;
+       nodeId != BitmaskImpl::NotFound;
+       nodeId = sortedNodes.find_next(nodeId + 1), i++)
+  {
+    ndbrequire(i < noOfReplicas);
+    Uint32 idx = (nodeIndex + i) % noOfReplicas;
+    indexPtr.p->indexStatNodes[idx] = nodeId;
   }
+
   D("set_index_stat_frag" << V(indexId) << V(fragId)
     << V(indexPtr.p->indexStatNodes[0]));
 }