Skip to content

Commit 7ef5a41

Browse files
Fix get_online_features telemetry to only log every 10000 times (feast-dev#1786)
* Fix get_online_features telemetry to only log every 10000 times Signed-off-by: Felix Wang <[email protected]> * Avoid int overflow Signed-off-by: Felix Wang <[email protected]> * Log telemetry on second but not first call Signed-off-by: Felix Wang <[email protected]>
1 parent da436b5 commit 7ef5a41

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

sdk/python/feast/usage.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,10 @@ def log(self, function_name: str):
7777
self.check_env_and_configure()
7878
if self._usage_enabled and self.usage_id:
7979
if function_name == "get_online_features":
80-
if self._usage_counter["get_online_features"] % 10000 != 0:
81-
self._usage_counter["get_online_features"] += 1
80+
self._usage_counter["get_online_features"] += 1
81+
if self._usage_counter["get_online_features"] % 10000 != 2:
8282
return
83-
83+
self._usage_counter["get_online_features"] = 2 # avoid overflow
8484
json = {
8585
"function_name": function_name,
8686
"telemetry_id": self.usage_id,

0 commit comments

Comments
 (0)