Bug#35847193 Cluster code fails to compile on Ubuntu23.10

Maitrayi Sabaratnam · bjornmu · commit 4b994b05221c · 2023-10-12T11:07:32.000+02:00
Fixing compiler warning by adding a check to ensure accessing array element within the range.

Reviewed by: Mauritz Sundell &lt;mauritz.sundell@oracle.com&gt;

Change-Id: I55a0a72b5f7733e069bcd229ff49e45ed3bf38cb
diff --git a/storage/ndb/include/util/Bitmask.hpp b/storage/ndb/include/util/Bitmask.hpp
@@ -307,6 +307,7 @@ BitmaskImpl::setRange(unsigned size [[maybe_unused]], Uint32 data[],
     return;
   }
 
+  assert(start < (size << 5));
   Uint32 last = start + len - 1;
   Uint32 *ptr = data + (start >> 5);
   Uint32 *end =  data + (last >> 5);

Original file line number	Diff line number	Diff line change
`@@ -307,6 +307,7 @@ BitmaskImpl::setRange(unsigned size [[maybe_unused]], Uint32 data[],`
`307`	`307`	`return;`
`308`	`308`	`}`
`309`	`309`
	`310`	`+ assert(start < (size << 5));`
`310`	`311`	`Uint32 last = start + len - 1;`
`311`	`312`	`Uint32 *ptr = data + (start >> 5);`
`312`	`313`	`Uint32 *end = data + (last >> 5);`