Skip to content

Commit a2b9286

Browse files
author
Dave Conway-Jones
committed
Fix slider not sending if mouse leaves widget in "on release" mode
Bump for 2.16.1 release
1 parent 64ae7ee commit a2b9286

File tree

6 files changed

+19
-7
lines changed

6 files changed

+19
-7
lines changed

CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
1-
### 2.16.1-beta: Maintenance Release
1+
### 2.16.1: Maintenance Release
22

33
**Fixes**
44

55
- Fix toast to show border correctly and better timing. Issue #525
66
- Stop colour picker sending on page refresh. Issue #514
7+
- Fix layout tool group locations. PR #526
8+
- Fix slider not sending if past end of widget.
79

810
### 2.16.0: Milestone Release
911

@@ -12,7 +14,6 @@
1214
- Add Dashboard Layout tool - Major contribution - Thanks @KazuhiroItoh - PR #482
1315
- Add ui.isDark() returns true/false if overall theme is dark or light, so the widget could switch appropriately. (can already use getTheme() to get actual colors if needs be.)
1416

15-
1617
**Fixes**
1718

1819
- Make spacer transparent so background is really the background.

dist/dashboard.appcache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ fonts/weather-icons-lite.woff2
2424
NETWORK:
2525
*
2626

27-
# hash: 8a5a27b1b3e0752f766fd30d3aef8dab54f94ffd3cef3367cb8682398d02c5f4
27+
# hash: c7a9da31046037ec87dbb181b5f538434256aa3b2757b1b0203472aef39d5e06

dist/js/app.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "node-red-dashboard",
3-
"version": "2.16.1-beta",
3+
"version": "2.16.1",
44
"description": "A set of dashboard nodes for Node-RED",
55
"keywords": [
66
"node-red"

src/components/ui-component/templates/slider.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@
2929
step="{{me.item.step}}"
3030
ng-model="me.item.value"
3131
aria-label="{{me.item.label}}"
32+
ng-change="me.mchange()"
3233
ng-mouseup="me.valueChanged(10)"
34+
ng-mousedown="me.mdown()"
35+
ng-mouseleave="me.mleave()"
3336
style="z-index:1; touch-action:none; min-width:32px;"
3437
ng-style="(me.item.width >= me.item.height) && {'margin-top':'20px'};"
3538
ng-attr-md-vertical="{{ (me.item.width < me.item.height) || undefined}}"

src/components/ui-component/ui-component-ctrl.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,12 +276,20 @@ angular.module('ui').controller('uiComponentController', ['$scope', 'UiEvents',
276276
}
277277
break;
278278
}
279+
280+
case 'slider': {
281+
me.active = false;
282+
me.mdown = function() { me.active = true; };
283+
me.mleave = function() { me.active = false; };
284+
me.mchange = function() { events.emit({ id:me.item.id, value:me.item.value });}
285+
break;
286+
}
279287
}
280288
}
281289

282290
me.valueChanged = function (throttleTime) {
283291
throttle({ id:me.item.id, value:me.item.value },
284-
typeof throttleTime === "number" ? throttleTime : 10);
292+
typeof throttleTime === "number" ? throttleTime : 10);
285293
};
286294

287295
// will emit me.item.value when enter or tab is pressed or onBlur

0 commit comments

Comments
 (0)