CSS: Stop Firefox from treating disconnected elements as cascade-hidden

gibson042 · timmywil · commit fe05cf37ffd4 · 2016-01-14T17:53:39.000-05:00
Fixes jquerygh-2833 Ref dba93f7 Close jquerygh-2835
diff --git a/src/css/showHide.js b/src/css/showHide.js
@@ -54,7 +54,12 @@ function showHide( elements, show ) {
 					elem.style.display = "";
 				}
 			}
-			if ( elem.style.display === "" && jQuery.css( elem, "display" ) === "none" ) {
+			if ( elem.style.display === "" && jQuery.css( elem, "display" ) === "none" &&
+
+					// Support: Firefox <=42 - 43
+					// Don't set inline display on disconnected elements with computed display: none
+					jQuery.contains( elem.ownerDocument, elem ) ) {
+
 				values[ index ] = getDefaultDisplay( elem );
 			}
 		} else {

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,12 @@ function showHide( elements, show ) {`
`54`	`54`	`elem.style.display = "";`
`55`	`55`	`}`
`56`	`56`	`}`
`57`		`- if ( elem.style.display === "" && jQuery.css( elem, "display" ) === "none" ) {`
	`57`	`+ if ( elem.style.display === "" && jQuery.css( elem, "display" ) === "none" &&`
	`58`	`+`
	`59`	`+ // Support: Firefox <=42 - 43`
	`60`	`+ // Don't set inline display on disconnected elements with computed display: none`
	`61`	`+ jQuery.contains( elem.ownerDocument, elem ) ) {`
	`62`	`+`
`58`	`63`	`values[ index ] = getDefaultDisplay( elem );`
`59`	`64`	`}`
`60`	`65`	`} else {`