Simplify SortTocFromFile() by removing fixed buffer-size limit.
authorTom Lane <[email protected]>
Tue, 22 Sep 2020 20:03:32 +0000 (16:03 -0400)
committerTom Lane <[email protected]>
Tue, 22 Sep 2020 20:03:32 +0000 (16:03 -0400)
commit2e3c19462da930d1d018caa3daabca00159b4b18
tree8046f06e968e47c2734b8d66ae16e8779305a070
parentc0cb87fbb6642222a99593785f77d318af06ef02
Simplify SortTocFromFile() by removing fixed buffer-size limit.

pg_restore previously coped with overlength TOC-file lines using some
complicated logic to ignore additional bufferloads.  While this isn't
wrong, since we don't expect that the interesting part of a line would
run to more than a dozen or so bytes, it's more complex than it needs
to be.  Use a StringInfo instead of a fixed-size buffer so that we can
process long lines as single entities and thus not need the extra
logic.

Daniel Gustafsson

Discussion: https://postgr.es/m/48A4FA71-524E-41B9-953A-FD04EF36E2E7@yesql.se
src/bin/pg_dump/pg_backup_archiver.c