Improve performance of float overflow checks in btree_gist
authorMichael Paquier <[email protected]>
Thu, 19 Aug 2021 01:42:44 +0000 (10:42 +0900)
committerMichael Paquier <[email protected]>
Thu, 19 Aug 2021 01:42:44 +0000 (10:42 +0900)
commit32cf7f7acce3891cbc3de53327704372bdd36d38
tree6bce685687873526523c6059fccc348cd4f53c30
parent2576dcfb76aa71e4222bac5a3a43f71875bfa9e8
Improve performance of float overflow checks in btree_gist

The current code could do unnecessary calls to isinf() (two for the
argument values all the time while one could be sufficient in some
cases).  zero_is_valid was never used but the result value was still
checked on 0 in the first position of the check.

This is similar to 607f8ce.  btree_gist has just copy-pasted the code
doing those checks from the backend float4/8 code, as of the macro
CHECKFLOATVAL(), to do the work.

Author: Haiying Tang
Discussion: https://postgr.es/m/OS0PR01MB611358E3A7BC3C2F874AC36BFBF39@OS0PR01MB6113.jpnprd01.prod.outlook.com
contrib/btree_gist/btree_float4.c
contrib/btree_gist/btree_float8.c
contrib/btree_gist/btree_utils_num.h