Improve stability of tests for VACUUM (SKIP_LOCKED)
authorMichael Paquier <[email protected]>
Sat, 16 Nov 2019 06:23:12 +0000 (15:23 +0900)
committerMichael Paquier <[email protected]>
Sat, 16 Nov 2019 06:23:12 +0000 (15:23 +0900)
commit3db0598d908f22435ab8138d1c76b971f17a5633
tree1271ba77e8570c705170a1004293e95c1f60faa5
parent2dc08bd6179d8cf480c93701010c19ad7a9891d8
Improve stability of tests for VACUUM (SKIP_LOCKED)

Concurrent autovacuums running with the main regression test suite
could cause the tests with VACUUM (SKIP_LOCKED) to generate randomly
WARNING messages.  For these tests, set client_min_messages to ERROR to
get rid of those random failures, as disabling autovacuum for the
relations operated would not completely close the failure window.

For isolation tests, disable autovacuum for the relations vacuumed with
SKIP_LOCKED.  The tests are designed so as LOCK commands are taken
in a first session before running a concurrent VACUUM (SKIP_LOCKED) in a
second to generate WARNING messages, but a concurrent autovacuum could
cause the tests to be slower.

Reported-by: Tom Lane
Author: Michael Paquier
Reviewed-by: Andres Freund, Tom Lane
Discussion: https://postgr.es/m/25294.1573077278@sss.pgh.pa.us
Backpatch-through: 12
src/test/isolation/specs/vacuum-skip-locked.spec
src/test/regress/expected/vacuum.out
src/test/regress/sql/vacuum.sql