More -Wshadow=compatible-local warning fixes
authorDavid Rowley <[email protected]>
Thu, 25 Aug 2022 14:35:40 +0000 (02:35 +1200)
committerDavid Rowley <[email protected]>
Thu, 25 Aug 2022 14:35:40 +0000 (02:35 +1200)
commit3e0fff2e6888e39b0ad5cdfdb78bc1c2bb2b22c9
tree235e23ee1c87eb2f148216535c0d300bcbe0a64e
parente3ce2de09d814f8770b2e3b3c152b7671bcdb83f
More -Wshadow=compatible-local warning fixes

In a similar effort to f01592f91, here we're targetting fixing the
warnings where we've deemed the shadowing variable to serve a close enough
purpose to the shadowed variable just to reuse the shadowed version and
not declare the shadowing variable at all.

By my count, this takes the warning count from 106 down to 71.

Author: Justin Pryzby
Discussion: https://postgr.es/m/20220825020839[email protected]
20 files changed:
src/backend/access/hash/hash_xlog.c
src/backend/access/transam/multixact.c
src/backend/access/transam/xlog.c
src/backend/commands/functioncmds.c
src/backend/commands/tablecmds.c
src/backend/commands/vacuum.c
src/backend/executor/execPartition.c
src/backend/executor/nodeWindowAgg.c
src/backend/lib/integerset.c
src/backend/libpq/auth.c
src/backend/optimizer/path/indxpath.c
src/backend/optimizer/plan/planner.c
src/backend/optimizer/plan/subselect.c
src/backend/optimizer/prep/prepunion.c
src/backend/postmaster/autovacuum.c
src/backend/rewrite/rowsecurity.c
src/backend/statistics/dependencies.c
src/backend/utils/adt/rangetypes_spgist.c
src/backend/utils/adt/ruleutils.c
src/bin/pgbench/pgbench.c