postgres_fdw: Fix unexpected reporting of empty message.
authorFujii Masao <[email protected]>
Fri, 3 Dec 2021 08:35:29 +0000 (17:35 +0900)
committerFujii Masao <[email protected]>
Fri, 3 Dec 2021 08:35:29 +0000 (17:35 +0900)
commit557c39bba925d553c6bb12b5e80d1964d355583b
tree7987098c0858ef05daf2ed80840aa1b1f5268bf7
parent03774f9bb304d49fae3379806115aaa5d1fafea2
postgres_fdw: Fix unexpected reporting of empty message.

pgfdw_report_error() in postgres_fdw gets a message from PGresult or
PGconn to report an error received from a remote server. Previously
if it could get a message from neither of them, it reported empty
message unexpectedly. The cause of this issue was that pgfdw_report_error()
didn't handle properly the case where no message could be obtained
and its local variable message_primary was set to '\0'.

This commit improves pgfdw_report_error() so that it reports the message
"could not obtain ..." when it gets no message and message_primary
is set to '\0'. This is the same behavior as when message_primary is NULL.

dblink_res_error() in dblink has the same issue, so this commit also
improves it in the same way.

Back-patch to all supported branches.

Author: Fujii Masao
Reviewed-by: Bharath Rupireddy
Discussion: https://postgr.es/m/477c16c8-7ea4-20fc-38d5-ed3a77ed616c@oss.nttdata.com
contrib/dblink/dblink.c
contrib/postgres_fdw/connection.c