Improve coding of column-name parsing in psql's new crosstabview.c.
authorTom Lane <[email protected]>
Tue, 12 Apr 2016 16:52:35 +0000 (12:52 -0400)
committerTom Lane <[email protected]>
Tue, 12 Apr 2016 16:52:42 +0000 (12:52 -0400)
commit7a5f8b5c59033ac153963f98b9109be9529a824a
tree4b05c702846dfaeaee14e96e72b02af1771b2588
parent2201d801b03c2d1b0bce4d6580b718dc34d38b3e
Improve coding of column-name parsing in psql's new crosstabview.c.

Coverity complained about this code, not without reason because it was
rather messy.  Adjust it to not scribble on the passed string; that adds
one malloc/free cycle per column name, which is going to be insignificant
in context.  We can actually const-ify both the string argument and the
PGresult.

Daniel Verité, with some further cleanup by me
src/bin/psql/crosstabview.c
src/bin/psql/crosstabview.h