Add missing check_collation_set call to bpcharne().
authorTom Lane <[email protected]>
Wed, 13 Nov 2019 20:53:53 +0000 (15:53 -0500)
committerTom Lane <[email protected]>
Wed, 13 Nov 2019 20:53:53 +0000 (15:53 -0500)
commitd57d61533a2b5b27b60cc9024c54688390871bf6
tree717b67c402d8f292c9f7b8e3b26f1174a3509953
parent0cafdd03a850265006c0ada1b0bf4f83e087a409
Add missing check_collation_set call to bpcharne().

We should throw an error for indeterminate collation, but bpcharne()
was missing that logic, resulting in a much less user-friendly error
(either an assertion failure or "cache lookup failed for collation 0").

Per report from Manuel Rigger.  Back-patch to v12 where the mistake
came in, evidently in commit 5e1963fb7.  (Before non-deterministic
collations, this function wasn't collation sensitive.)

Discussion: https://postgr.es/m/CA+u7OA4HOjtymxAbuGNh4-X_2R0Lw5n01tzvP8E5-i-2gQXYWA@mail.gmail.com
src/backend/utils/adt/varchar.c