Fix incorrect logic in plan dependency recording
authorDavid Rowley <[email protected]>
Wed, 13 Sep 2023 23:27:29 +0000 (11:27 +1200)
committerDavid Rowley <[email protected]>
Wed, 13 Sep 2023 23:27:29 +0000 (11:27 +1200)
commitee3a551e96c465f96de04dd1faf4e7bff8d25342
treef44a8158b5ab3c66346f6ae891f59cde91fe12e1
parentf062cddafe6b3dcb6d090111c7cd4afa0c7fa4b3
Fix incorrect logic in plan dependency recording

Both 50e17ad28 and 29f45e299 mistakenly tried to record a plan dependency
on a function but mistakenly inverted the OidIsValid test.  This meant
that we'd record a dependency only when the function's Oid was
InvalidOid.  Clearly this was meant to *not* record the dependency in
that case.

50e17ad28 made this mistake first, then in v15 29f45e299 copied the same
mistake.

Reported-by: Tom Lane
Backpatch-through: 14, where 50e17ad28 first made this mistake
Discussion: https://postgr.es/m/2277537.1694301772@sss.pgh.pa.us
src/backend/optimizer/plan/setrefs.c