Fix Assert failure in XMLTABLE parser master github/master
authorRichard Guo <[email protected]>
Thu, 15 May 2025 08:09:04 +0000 (17:09 +0900)
committerRichard Guo <[email protected]>
Thu, 15 May 2025 08:09:04 +0000 (17:09 +0900)
commitfe29b2a1dab2b3d81e6c350679b7d9b0e1c8c850
treed3178a4ad1e430730f13d6e5cc57356f5be5414a
parent2c0ed86d393670c7054d051490063de771f1791e
Fix Assert failure in XMLTABLE parser

In an XMLTABLE expression, columns can be marked NOT NULL, and the
parser internally fabricates an option named "is_not_null" to
represent this.  However, the parser also allows users to specify
arbitrary option names.  This creates a conflict: a user can
explicitly use "is_not_null" as an option name and assign it a
non-Boolean value, which violates internal assumptions and triggers an
assertion failure.

To fix, this patch checks whether a user-supplied name collides with
the internally reserved option name and raises an error if so.
Additionally, the internal name is renamed to "__pg__is_not_null" to
further reduce the risk of collision with user-defined names.

Reported-by: Евгений Горбанев <[email protected]>
Author: Richard Guo <[email protected]>
Reviewed-by: Alvaro Herrera <[email protected]>
Discussion: https://postgr.es/m/6bac9886-65bf-4cec-96bd-e304159f28db@basealt.ru
Backpatch-through: 15
src/backend/parser/gram.y
src/test/regress/expected/xml.out
src/test/regress/expected/xml_1.out
src/test/regress/expected/xml_2.out
src/test/regress/sql/xml.sql