Make pg_dump emit a useful error message, instead of just dumping core,

if it finds a pg_rewrite entry for which there is no pg_class entry.
Per report from Andrew Slobodyanyk.

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index e2fb805d59eefb5e6f19009dc3caecb2fb6c59aa..f4e7c6e5f1f0eacc475edc0821449084048adbc3 100644 (file)
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -12,7 +12,7 @@
  *     by PostgreSQL
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.403 2005/02/22 04:39:35 momjian Exp $
+ *       $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.404 2005/03/14 18:57:33 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -3154,6 +3154,13 @@ getRules(int *numRules)
                ruleinfo[i].dobj.name = strdup(PQgetvalue(res, i, i_rulename));
                ruletableoid = atooid(PQgetvalue(res, i, i_ruletable));
                ruleinfo[i].ruletable = findTableByOid(ruletableoid);
+               if (ruleinfo[i].ruletable == NULL)
+               {
+                       write_msg(NULL, "failed sanity check, parent table OID %u of pg_rewrite entry OID %u not found\n",
+                                         ruletableoid,
+                                         ruleinfo[i].dobj.catId.oid);
+                       exit_nicely();
+               }
                ruleinfo[i].dobj.namespace = ruleinfo[i].ruletable->dobj.namespace;
                ruleinfo[i].ev_type = *(PQgetvalue(res, i, i_ev_type));
                ruleinfo[i].is_instead = *(PQgetvalue(res, i, i_is_instead)) == 't';