Initialize structure at declaration

Avoids extra memset call and cast.

Discussion: https://www.postgresql.org/message-id/flat/7a5cbea7-b8df-e910-0f10-04014bcad701%402ndquadrant.com

diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
index d95e6bfa71527521798dcd07fe48d6f8c72c6e0a..d35e5ba3d88c8df2942a23e79d49a24ba9f7db50 100644 (file)
--- a/contrib/dblink/dblink.c
+++ b/contrib/dblink/dblink.c
@@ -982,13 +982,11 @@ materializeQueryResult(FunctionCallInfo fcinfo,
 {
        ReturnSetInfo *rsinfo = (ReturnSetInfo *) fcinfo->resultinfo;
        PGresult   *volatile res = NULL;
-       volatile storeInfo sinfo;
+       volatile storeInfo sinfo = {0};
 
        /* prepTuplestoreResult must have been called previously */
        Assert(rsinfo->returnMode == SFRM_Materialize);
 
-       /* initialize storeInfo to empty */
-       memset((void *) &sinfo, 0, sizeof(sinfo));
        sinfo.fcinfo = fcinfo;
 
        PG_TRY();