Fix bugs in PQhost().

In the platform that doesn't support Unix-domain socket, when
neither host nor hostaddr are specified, the default host
'localhost' is used to connect to the server and PQhost() must
return that, but it didn't. This patch fixes PQhost() so that
it returns the default host in that case.

Also this patch fixes PQhost() so that it doesn't return
Unix-domain socket directory path in the platform that doesn't
support Unix-domain socket.

Back-patch to all supported versions.

diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index fa88c874945f74a6f5e8a151aae584cdcdcf8a0b..92cdd2cbe3524fc9012ce6fb3ffaf217c6184f7f 100644 (file)
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -5188,7 +5188,16 @@ PQhost(const PGconn *conn)
 {
        if (!conn)
                return NULL;
-       return conn->pghost ? conn->pghost : conn->pgunixsocket;
+       if (conn->pghost != NULL && conn->pghost[0] != '\0')
+               return conn->pghost;
+       else
+       {
+#ifdef HAVE_UNIX_SOCKETS
+               return conn->pgunixsocket;
+#else
+               return DefaultHost;
+#endif
+       }
 }
 
 char *