Remove unused arguments in two GiST subroutines
authorAlvaro Herrera <[email protected]>
Tue, 28 Jun 2016 20:01:13 +0000 (16:01 -0400)
committerAlvaro Herrera <[email protected]>
Tue, 28 Jun 2016 20:01:13 +0000 (16:01 -0400)
These arguments became unused in commit 2c03216d8311.  Noticed while
skimming code for unrelated development.

This is cosmetic, so no backpatch.

src/backend/access/gist/gist.c
src/backend/access/gist/gistvacuum.c
src/backend/access/gist/gistxlog.c
src/include/access/gist_private.h

index fdf0c5a5cf4d05bd570617248af1fd64aa5875d3..e8034b9cd6d013d31361006a6f6012577818ea15 100644 (file)
@@ -467,7 +467,7 @@ gistplacetopage(Relation rel, Size freespace, GISTSTATE *giststate,
 
        /* Write the WAL record */
        if (RelationNeedsWAL(rel))
-           recptr = gistXLogSplit(rel->rd_node, blkno, is_leaf,
+           recptr = gistXLogSplit(is_leaf,
                                   dist, oldrlink, oldnsn, leftchildbuf,
                                   markfollowright);
        else
@@ -523,7 +523,7 @@ gistplacetopage(Relation rel, Size freespace, GISTSTATE *giststate,
                ndeloffs = 1;
            }
 
-           recptr = gistXLogUpdate(rel->rd_node, buffer,
+           recptr = gistXLogUpdate(buffer,
                                    deloffs, ndeloffs, itup, ntup,
                                    leftchildbuf);
 
@@ -1541,7 +1541,7 @@ gistvacuumpage(Relation rel, Page page, Buffer buffer)
        {
            XLogRecPtr  recptr;
 
-           recptr = gistXLogUpdate(rel->rd_node, buffer,
+           recptr = gistXLogUpdate(buffer,
                                    deletable, ndeletable,
                                    NULL, 0, InvalidBuffer);
 
index 7947ff9dbe6a5cc88977332ad8606a0900daf5c8..53e5cea580fd1a25fbe451661bb05708c7dcaf5c 100644 (file)
@@ -223,7 +223,7 @@ gistbulkdelete(IndexVacuumInfo *info, IndexBulkDeleteResult *stats,
                {
                    XLogRecPtr  recptr;
 
-                   recptr = gistXLogUpdate(rel->rd_node, buffer,
+                   recptr = gistXLogUpdate(buffer,
                                            todelete, ntodelete,
                                            NULL, 0, InvalidBuffer);
                    PageSetLSN(page, recptr);
index b48e97cc66eb9b6361278ab34a245fc4b9dd4832..01c7ef7ea6796e6ac413c2ce84fe59fb34d30b7f 100644 (file)
@@ -323,7 +323,7 @@ gist_xlog_cleanup(void)
  * Write WAL record of a page split.
  */
 XLogRecPtr
-gistXLogSplit(RelFileNode node, BlockNumber blkno, bool page_is_leaf,
+gistXLogSplit(bool page_is_leaf,
              SplitedPageLayout *dist,
              BlockNumber origrlink, GistNSN orignsn,
              Buffer leftchildbuf, bool markfollowright)
@@ -387,7 +387,7 @@ gistXLogSplit(RelFileNode node, BlockNumber blkno, bool page_is_leaf,
  * to log the whole buffer contents instead.
  */
 XLogRecPtr
-gistXLogUpdate(RelFileNode node, Buffer buffer,
+gistXLogUpdate(Buffer buffer,
               OffsetNumber *todelete, int ntodelete,
               IndexTuple *itup, int ituplen,
               Buffer leftchildbuf)
index f9732ba7fb93dac1990e90b0b005ab7543d33d3b..23e0fe3197862f30b1afcb1354eaf9c55f8a67c2 100644 (file)
@@ -465,13 +465,12 @@ extern const char *gist_identify(uint8 info);
 extern void gist_xlog_startup(void);
 extern void gist_xlog_cleanup(void);
 
-extern XLogRecPtr gistXLogUpdate(RelFileNode node, Buffer buffer,
+extern XLogRecPtr gistXLogUpdate(Buffer buffer,
               OffsetNumber *todelete, int ntodelete,
               IndexTuple *itup, int ntup,
               Buffer leftchild);
 
-extern XLogRecPtr gistXLogSplit(RelFileNode node,
-             BlockNumber blkno, bool page_is_leaf,
+extern XLogRecPtr gistXLogSplit(bool page_is_leaf,
              SplitedPageLayout *dist,
              BlockNumber origrlink, GistNSN oldnsn,
              Buffer leftchild, bool markfollowright);