Restart the apply worker if the 'password_required' option is changed.

The apply worker is restarted if any subscription option that affects the
remote connection was changed. In commit c3afe8cf5a, we added the option
'password_required' which can affect the remote connection, so we should
restart the worker if it was changed.

Author: Amit Kapila
Reviewed-by: Robert Haas
Discussion: https://postgr.es/m/CAA4eK1+z9UDFEynXLsWeMMuUZc1iQkRwj2HNDtxUHTPo-u1F4A@mail.gmail.com
Discussion: https://postgr.es/m/9DFC88D3-1300-4DE8-ACBC-4CEF84399A53@enterprisedb.com

diff --git a/src/backend/replication/logical/worker.c b/src/backend/replication/logical/worker.c
index 3d58910c145d714c06bc7e1ff3b33f5c69d40db9..37bb88412790e38f139b0a0150ed904b46fa38d3 100644 (file)
--- a/src/backend/replication/logical/worker.c
+++ b/src/backend/replication/logical/worker.c
@@ -3934,6 +3934,7 @@ maybe_reread_subscription(void)
                strcmp(newsub->slotname, MySubscription->slotname) != 0 ||
                newsub->binary != MySubscription->binary ||
                newsub->stream != MySubscription->stream ||
+               newsub->passwordrequired != MySubscription->passwordrequired ||
                strcmp(newsub->origin, MySubscription->origin) != 0 ||
                newsub->owner != MySubscription->owner ||
                !equal(newsub->publications, MySubscription->publications))