Suppress warning from older compilers.

Commit 8af1624e3 introduced a warning about possibly returning
without a value, on compilers that don't realize that ereport(ERROR)
doesn't return.  Tweak the code to avoid that.

Per buildfarm.  Back-patch to 9.6, like the aforesaid commit.

diff --git a/src/backend/tsearch/spell.c b/src/backend/tsearch/spell.c
index 1b8766659c49f1f7045d0d8fee8e06cbe6998a7c..abc31cb356d4386aeda57fb14ddd57f5983deda5 100644 (file)
--- a/src/backend/tsearch/spell.c
+++ b/src/backend/tsearch/spell.c
@@ -1173,8 +1173,7 @@ getAffixFlagSet(IspellDict *Conf, char *s)
                        ereport(ERROR,
                                        (errcode(ERRCODE_CONFIG_FILE_ERROR),
                                         errmsg("invalid affix alias \"%s\"", s)));
-               else
-                       return VoidString;
+               return VoidString;
        }
        else
                return s;