Fix check for trapping exit() calls in libpq
authorDaniel Gustafsson <[email protected]>
Mon, 4 Oct 2021 19:04:11 +0000 (21:04 +0200)
committerDaniel Gustafsson <[email protected]>
Mon, 4 Oct 2021 19:04:11 +0000 (21:04 +0200)
Commit e9bc0441f added an errorhint on the exit() check for libpq, but
accidentally changed the nm commandline to use -a instead of -A. These
options are similar enough to hide it in testing, but -a can also show
debugger symbols which isn't what we want. Fix by reverting the check
back to using -A again.

Reported-by: Anton Voloshin <[email protected]>
Discussion: https://postgr.es/m/bd2c8409-d6b3-5de9-ba0f-40c1381f630f@postgrespro.ru

src/interfaces/libpq/Makefile

index d98bc071439689be8bbc4e2f5f3eafd917b92444..40a96c881d64441d0aebff60cb02522e958cbd5f 100644 (file)
@@ -115,7 +115,7 @@ backend_src = $(top_srcdir)/src/backend
 libpq-refs-stamp: $(shlib)
 ifneq ($(enable_coverage), yes)
 ifeq (,$(filter aix solaris,$(PORTNAME)))
-   @if nm -a -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit; then \
+   @if nm -A -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit; then \
        echo 'libpq must not be calling any function which invokes exit'; exit 1; \
    fi
 endif