Fix pg_dump to omit whole of OPTIONS clause when the foreign table

has no generic option.

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index e9872b8996e041650972e0faae2f6c447ea33fdd..8f7ece479b80b754bff8a08e6f6111ccafa8181e 100644 (file)
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -11012,7 +11012,7 @@ dumpTableSchema(Archive *fout, TableInfo *tbinfo)
                k;
    bool        toast_set = false;
    char       *srvname;
-   char       *ftoptions;
+   char       *ftoptions = NULL;
 
    /* Make sure we are in proper schema */
    selectSourceSchema(tbinfo->dobj.namespace->dobj.name);
@@ -11287,7 +11287,8 @@ dumpTableSchema(Archive *fout, TableInfo *tbinfo)
            appendPQExpBuffer(q, ")");
        }
 
-       if (tbinfo->relkind == RELKIND_FOREIGN_TABLE)
+       /* Dump generic options if any */
+       if (ftoptions && ftoptions[0])
            appendPQExpBuffer(q, "\nOPTIONS (%s)", ftoptions);
 
        appendPQExpBuffer(q, ";\n");