From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 30 Jun 2015 16:53:54 +0000 (-0400)
Subject: Remove useless check for NULL subexpression.
X-Git-Url: http://git.postgresql.org/gitweb/-?a=commitdiff_plain;h=131926a52da0fbd77678cbd887914c83b48faa2d;p=users%2Frhaas%2Fpostgres.git

Remove useless check for NULL subexpression.

Coverity rightly gripes that it's silly to have a test here when
the adjacent ExecEvalExpr() would choke on a NULL expression pointer.

Petr Jelinek
---

diff --git a/src/backend/access/tablesample/tablesample.c b/src/backend/access/tablesample/tablesample.c
index 44a24340f6..f21d42c8e3 100644
--- a/src/backend/access/tablesample/tablesample.c
+++ b/src/backend/access/tablesample/tablesample.c
@@ -103,19 +103,13 @@ tablesample_init(SampleScanState *scanstate, TableSampleClause *tablesample)
 		fcinfo.argnull[1] = false;
 	}
 
-	/* Rest of the arguments come from user.  */
+	/* Rest of the arguments come from user. */
 	i = 2;
 	foreach(arg, args)
 	{
 		Expr	   *argexpr = (Expr *) lfirst(arg);
 		ExprState  *argstate = ExecInitExpr(argexpr, (PlanState *) scanstate);
 
-		if (argstate == NULL)
-		{
-			fcinfo.argnull[i] = true;
-			fcinfo.arg[i] = (Datum) 0;;
-		}
-
 		fcinfo.arg[i] = ExecEvalExpr(argstate, econtext,
 									 &fcinfo.argnull[i], NULL);
 		i++;