From: John Naylor <john.naylor@postgresql.org>
Date: Tue, 20 Dec 2022 07:13:14 +0000 (+0700)
Subject: Move variable increment to the end of the loop
X-Git-Url: http://git.postgresql.org/gitweb/-?a=commitdiff_plain;h=995a9fb14f6aa81ad8eedaf4e8dce1b3e51105c0;p=users%2Frhaas%2Fpostgres.git

Move variable increment to the end of the loop

This is less error prone and matches the placement of other code
in the file.

Justin Pryzby

Reviewed by Tom Lane
Discussion: https://www.postgresql.org/message-id/20221123172436.GJ11463@telsasoft.com
---

diff --git a/src/backend/utils/activity/backend_status.c b/src/backend/utils/activity/backend_status.c
index 7ecf467b8c..cf5582caf2 100644
--- a/src/backend/utils/activity/backend_status.c
+++ b/src/backend/utils/activity/backend_status.c
@@ -842,7 +842,6 @@ pgstat_read_current_status(void)
 			CHECK_FOR_INTERRUPTS();
 		}
 
-		beentry++;
 		/* Only valid entries get included into the local array */
 		if (localentry->backendStatus.st_procpid > 0)
 		{
@@ -871,6 +870,8 @@ pgstat_read_current_status(void)
 #endif
 			localNumBackends++;
 		}
+
+		beentry++;
 	}
 
 	/* Set the pointer only after completion of a valid table */