From: Daniel Gustafsson Date: Mon, 4 Oct 2021 12:32:21 +0000 (+0200) Subject: Provide error hint on exit() check when building libpq X-Git-Url: http://git.postgresql.org/gitweb/-?a=commitdiff_plain;h=e9bc0441f1446f6614fa6712841acec91890e089;p=users%2Frhaas%2Fpostgres.git Provide error hint on exit() check when building libpq Commit dc227eb82 introduced a restriction on libpq that no functions which invoke exit() are allowed to be called. This was further refined and fixed in e45b0dfa1f and 2f7bae2f92 and 792259591. While this is well documented in the Makefile, the error message emitted when the check failed was terse, without hints for new developers without prior context. This adds an error hint to assist new developers onboarding to postgres. Author: Rachel Heaton Co-authored-by: Jacob Champion Discussion: https://postgr.es/m/CADJcwiVL20955HCNzDqz9BEDr6A77pz6-nac5sbZVvhAEMijLg@mail.gmail.com --- diff --git a/src/interfaces/libpq/Makefile b/src/interfaces/libpq/Makefile index 7cbdeb589b..d98bc07143 100644 --- a/src/interfaces/libpq/Makefile +++ b/src/interfaces/libpq/Makefile @@ -115,7 +115,9 @@ backend_src = $(top_srcdir)/src/backend libpq-refs-stamp: $(shlib) ifneq ($(enable_coverage), yes) ifeq (,$(filter aix solaris,$(PORTNAME))) - ! nm -A -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit + @if nm -a -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit; then \ + echo 'libpq must not be calling any function which invokes exit'; exit 1; \ + fi endif endif touch $@