From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sat, 23 Mar 2019 21:40:19 +0000 (-0400)
Subject: Remove inadequate check for duplicate "xml" PI.
X-Git-Url: http://git.postgresql.org/gitweb/-?a=commitdiff_plain;h=f778e537a0d02d5e05016da3e6f4068914101dee;p=users%2Frhaas%2Fpostgres.git

Remove inadequate check for duplicate "xml" PI.

I failed to think about PIs starting with "xml".  We don't really
need this check at all, so just take it out.  Oversight in
commit 8d1dadb25 et al.
---

diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c
index f6bc499320..a0017ea893 100644
--- a/src/backend/utils/adt/xml.c
+++ b/src/backend/utils/adt/xml.c
@@ -1496,10 +1496,6 @@ xml_doctype_in_content(const xmlChar *str)
 		if (!e)
 			return false;
 
-		/* we don't check PIs carefully, but do reject "xml" target */
-		if (e - p >= 3 && xmlStrncasecmp(p, (xmlChar *) "xml", 3) == 0)
-			return false;
-
 		/* advance over PI, keep scanning */
 		p = e + 2;
 	}