Tom Lane [Tue, 22 Mar 2005 06:17:03 +0000 (06:17 +0000)]
Create a routine PageIndexMultiDelete() that replaces a loop around
PageIndexTupleDelete() with a single pass of compactification ---
logic mostly lifted from PageRepairFragmentation. I noticed while
profiling that a VACUUM that's cleaning up a whole lot of deleted
tuples would spend as much as a third of its CPU time in
PageIndexTupleDelete; not too surprising considering the loop method
was roughly O(N^2) in the number of tuples involved.
Tom Lane [Mon, 21 Mar 2005 16:29:20 +0000 (16:29 +0000)]
Fix quote_ident to use quote_identifier rather than its own, not quite
up-to-speed logic; in particular this will cause it to quote names that
match keywords. Remove unnecessary multibyte cruft from quote_literal
(all backend-internal encodings are 8-bit-safe).
Neil Conway [Mon, 21 Mar 2005 05:24:52 +0000 (05:24 +0000)]
pgcrypto update:
* test error handling
* add tests for des, 3des, cast5
* add some tests to blowfish, rijndael
* Makefile: ability to specify different tests for different crypto
libraries, so we can skip des, 3des and cast5 for builtin.
Marko Kreen
Neil Conway [Mon, 21 Mar 2005 05:22:14 +0000 (05:22 +0000)]
pgcrypto update:
Reserve px_get_random_bytes() for strong randomness,
add new function px_get_pseudo_random_bytes() for
weak randomness and use it in gen_salt().
On openssl case, use RAND_pseudo_bytes() for
px_get_pseudo_random_bytes().
Final result is that is user has not configured random
souce but kept the 'silly' one, gen_salt() keeps
working, but pgp_encrypt() will throw error.
Marko Kreen
Neil Conway [Mon, 21 Mar 2005 05:21:04 +0000 (05:21 +0000)]
pgcrypto update:
* openssl.c: Add 3des and AES support
* README.pgcrypto: list only supported ciphers for openssl
OpenSSL has pre-processor symbol OPENSSL_NO_AES, which
isn't that helpful for detecting if it _does_ exist.
Thus the hack with AES_ENCRYPT.
Marko Kreen
Neil Conway [Mon, 21 Mar 2005 05:19:55 +0000 (05:19 +0000)]
pgcrypto update:
* Use error codes instead of -1
* px_strerror for new error codes
* calling convention change for px_gen_salt - return error code
* use px_strerror in pgcrypto.c
Marko Kreen
Neil Conway [Mon, 21 Mar 2005 05:18:46 +0000 (05:18 +0000)]
* construct "struct {} list [] = {}" confuses pgindent - split those.
It was a bad style to begin with, and now several loops can be clearer.
* pgcrypto.c: Fix function comments
* crypt-gensalt.c, crypt-blowfish.c: stop messing with errno
* openssl.c: use px_free instead pfree
* px.h: make redefining px_alloc/px_realloc/px_free easier
Marko Kreen
Neil Conway [Mon, 21 Mar 2005 05:17:16 +0000 (05:17 +0000)]
Remove support for libmhash/libmcrypt.
libmcrypt seems to dead, maintainer address bounces,
and cast-128 fails on 2 of the 3 test vectors from RFC2144.
So I see no reason to keep around stuff I don't trust
anymore.
Support for several crypto libraries is probably only
confusing to users, although it was good for initial
developing - it helped to find hidden assumptions and
forced me to create regression tests for all functionality.
Marko Kreen
Tom Lane [Mon, 21 Mar 2005 01:24:04 +0000 (01:24 +0000)]
Convert index-related tuple handling routines from char 'n'/' ' to bool
convention for isnull flags. Also, remove the useless InsertIndexResult
return struct from index AM aminsert calls --- there is no reason for
the caller to know where in the index the tuple was inserted, and we
were wasting a palloc cycle per insert to deliver this uninteresting
value (plus nontrivial complexity in some AMs).
I forced initdb because of the change in the signature of the aminsert
routines, even though nothing really looks at those pg_proc entries...
Neil Conway [Sun, 20 Mar 2005 23:40:34 +0000 (23:40 +0000)]
Change the return value of HeapTupleSatisfiesUpdate() to be an enum,
rather than an integer, and fix the associated fallout. From Alvaro
Herrera.
Tom Lane [Sun, 20 Mar 2005 22:27:52 +0000 (22:27 +0000)]
On Windows, use QueryPerformanceCounter instead of gettimeofday for
EXPLAIN ANALYZE instrumentation. Magnus Hagander
Tom Lane [Sun, 20 Mar 2005 22:00:54 +0000 (22:00 +0000)]
Remove unnecessary calls of FlushRelationBuffers: there is no need
to write out data that we are about to tell the filesystem to drop.
smgr_internal_unlink already had a DropRelFileNodeBuffers call to
get rid of dead buffers without a write after it's no longer possible
to roll back the deleting transaction. Adding a similar call in
smgrtruncate simplifies callers and makes the overall division of
labor clearer. This patch removes the former behavior that VACUUM
would write all dirty buffers of a relation unconditionally.
Bruce Momjian [Sun, 20 Mar 2005 13:54:53 +0000 (13:54 +0000)]
Add mention of why malloc() has to be used in snprintf.c.
Bruce Momjian [Sun, 20 Mar 2005 03:53:39 +0000 (03:53 +0000)]
Department of second thoughts. Remove FRONTEND from snprintf.c because
snprintf is called before the memory system is started. We have to just
malloc/free. There are no elogs in the code so we should be fine.
Bruce Momjian [Sun, 20 Mar 2005 02:44:45 +0000 (02:44 +0000)]
Fix typo in Makefile.
Bruce Momjian [Sun, 20 Mar 2005 02:40:28 +0000 (02:40 +0000)]
Another change for FRONTEND snprintf.c.
Bruce Momjian [Sun, 20 Mar 2005 02:39:33 +0000 (02:39 +0000)]
Mark snprintf.c as a file that uses FRONTEND and needs to a version in
the server-side port library. Somehow I missed that change when I added
memory allocation to snprintf.c.
Bruce Momjian [Sun, 20 Mar 2005 01:57:11 +0000 (01:57 +0000)]
Done:
> * -Allow the size of the buffer cache used by temporary objects to be
Tom Lane [Sat, 19 Mar 2005 23:27:11 +0000 (23:27 +0000)]
Add temp_buffers GUC variable to allow users to determine the size
of the local buffer arena for temporary table access.
Tom Lane [Sat, 19 Mar 2005 17:39:43 +0000 (17:39 +0000)]
Upgrade localbuf.c to use a hash table instead of linear search to
find already-allocated local buffers. This is the last obstacle
in the way of setting NLocBuffer to something reasonably large.
Tom Lane [Fri, 18 Mar 2005 17:32:55 +0000 (17:32 +0000)]
Put 'dump complete' message in the right place, so it comes out where
it's supposed to when --file option is used.
Tom Lane [Fri, 18 Mar 2005 16:16:09 +0000 (16:16 +0000)]
Need to reset local buffer pin counts, not only shared buffer pins,
before we attempt any file deletions in ShutdownPostgres. Per Tatsuo.
Michael Meskes [Fri, 18 Mar 2005 10:00:43 +0000 (10:00 +0000)]
Added patch by Christof Petig <
[email protected]> to work around gcc bug on powerpc and amd64.
Tom Lane [Fri, 18 Mar 2005 05:25:23 +0000 (05:25 +0000)]
Avoid infinite loop in InvalidateBuffer if we ourselves are holding
a pin on the victim buffer.
Tom Lane [Fri, 18 Mar 2005 05:24:13 +0000 (05:24 +0000)]
Need to release buffer pins before attempting to drop files during
backend exit. Per report from Bruce.
Tom Lane [Fri, 18 Mar 2005 03:48:49 +0000 (03:48 +0000)]
Treat EPERM as a non-error case when checking to see if old postmaster
is still alive. This improves our odds of not getting fooled by an
unrelated process when checking a stale lock file. Other checks already
in place, plus one newly added in checkDataDir(), ensure that we cannot
attempt to usurp the place of a postmaster belonging to a different userid,
so there is no need to error out. Add comments indicating the importance
of these other checks.
Neil Conway [Thu, 17 Mar 2005 23:45:09 +0000 (23:45 +0000)]
This patch moves some code for preprocessing FOR UPDATE from
grouping_planner() to preprocess_targetlist(), according to a comment
in grouping_planner(). I think the refactoring makes sense, and moves
some extraneous details out of grouping_planner().
Bruce Momjian [Thu, 17 Mar 2005 20:24:34 +0000 (20:24 +0000)]
Add link to INSERT in docs.
Robert Treat
Bruce Momjian [Thu, 17 Mar 2005 15:38:46 +0000 (15:38 +0000)]
Update file system snapshot docs.
Tom Lane [Thu, 17 Mar 2005 15:25:51 +0000 (15:25 +0000)]
Update obsolete comment.
Neil Conway [Thu, 17 Mar 2005 05:47:01 +0000 (05:47 +0000)]
Trivial comment tweak.
Bruce Momjian [Thu, 17 Mar 2005 05:10:11 +0000 (05:10 +0000)]
Mention tablespaces as a problem for using file system snapshots.
Bruce Momjian [Thu, 17 Mar 2005 05:03:37 +0000 (05:03 +0000)]
Document use of rsync for file system backups.
Tino Wildenhain
Bruce Momjian [Thu, 17 Mar 2005 04:42:15 +0000 (04:42 +0000)]
Add mention of compatibility problem with turning off backslash escapes:
< SQL-spec compliant, so allow such handling to be disabled.
> SQL-spec compliant, so allow such handling to be disabled. However,
> disabling backslashes could break many third-party applications and tools.
Bruce Momjian [Thu, 17 Mar 2005 03:18:14 +0000 (03:18 +0000)]
Factor duplicate snprintf code into functions.
Neil Conway [Thu, 17 Mar 2005 00:22:24 +0000 (00:22 +0000)]
Add a reference to the documentation on alternate index operator classes in
the locale docs. Patch from Chris KL, editorialization by Neil Conway.
Neil Conway [Wed, 16 Mar 2005 23:52:18 +0000 (23:52 +0000)]
This patch makes \d on tables and views sort fk constraints, triggers
and rules alphabetically in the output. This makes it the same as
for indexes and stops the irritating random or reverse ordering it
currently has.
Chris KL
Bruce Momjian [Wed, 16 Mar 2005 22:59:42 +0000 (22:59 +0000)]
Force initdb cause of encoding additions.
Tom Lane [Wed, 16 Mar 2005 21:38:10 +0000 (21:38 +0000)]
Revise TupleTableSlot code to avoid unnecessary construction and disassembly
of tuples when passing data up through multiple plan nodes. A slot can now
hold either a normal "physical" HeapTuple, or a "virtual" tuple consisting
of Datum/isnull arrays. Upper plan levels can usually just copy the Datum
arrays, avoiding heap_formtuple() and possible subsequent nocachegetattr()
calls to extract the data again. This work extends Atsushi Ogawa's earlier
patch, which provided the key idea of adding Datum arrays to TupleTableSlots.
(I believe however that something like this was foreseen way back in Berkeley
days --- see the old comment on ExecProject.) A test case involving many
levels of join of fairly wide tables (about 80 columns altogether) showed
about 3x overall speedup, though simple queries will probably not be
helped very much.
I have also duplicated some code in heaptuple.c in order to provide versions
of heap_formtuple and friends that use "bool" arrays to indicate null
attributes, instead of the old convention of "char" arrays containing either
'n' or ' '. This provides a better match to the convention used by
ExecEvalExpr. While I have not made a concerted effort to get rid of uses
of the old routines, I think they should be deprecated and eventually removed.
Bruce Momjian [Wed, 16 Mar 2005 21:27:23 +0000 (21:27 +0000)]
Add sprintf support, that were were missing.
Add support for snprintf '+', 'h', and %* length settings.
Bruce Momjian [Wed, 16 Mar 2005 15:12:18 +0000 (15:12 +0000)]
pgindent snprintf.c for consistency.
Bruce Momjian [Wed, 16 Mar 2005 15:11:43 +0000 (15:11 +0000)]
Fix snprintf for %*$.
Bruce Momjian [Wed, 16 Mar 2005 06:05:53 +0000 (06:05 +0000)]
Add CVS \r\n regression tests.
Andrew Dunstan
Bruce Momjian [Wed, 16 Mar 2005 06:00:58 +0000 (06:00 +0000)]
Fix snprintf to handle %$ properly by storing and reordering the
arguments.
Nicolai Tufar
Bruce Momjian [Wed, 16 Mar 2005 01:49:10 +0000 (01:49 +0000)]
Add missing include for new lc_ctype_is_c() function.
Per Neil.
Bruce Momjian [Wed, 16 Mar 2005 00:02:49 +0000 (00:02 +0000)]
Prevent locale-aware handling of upper, lower, and initcap when the
locale is C.
Backpatch to 8.0.X because some operating systems were throwing errors
for such operations, rather than ignoring the locale when it was C.
Neil Conway [Wed, 16 Mar 2005 00:02:39 +0000 (00:02 +0000)]
Wrap the implementation of fork_process() inside #ifndef WIN32 -- this
should hopefully unbreak the Win32 build. Apologies for breaking it in
the first place.
Bruce Momjian [Tue, 15 Mar 2005 22:38:23 +0000 (22:38 +0000)]
Update to 8.0.1.
Bruce Momjian [Tue, 15 Mar 2005 05:31:27 +0000 (05:31 +0000)]
Add:
> * Allow sequential scans to take advantage of other concurrent
> sequentiqal scans, also called "Synchronised Scanning"
Bruce Momjian [Tue, 15 Mar 2005 04:01:21 +0000 (04:01 +0000)]
Update Win32 item:
< o Disallow encodings like UTF8 which PostgreSQL supports
< but the operating system does not (already disallowed by
< pginstaller)
> o Add support for Unicode
< To fix UTF8, the data needs to be converted to UTF16 and then
< the Win32 wcscoll() can be used, and perhaps other functions
> To fix this, the data needs to be converted to/from UTF16/UTF8
> so the Win32 wcscoll() can be used, and perhaps other functions
< locales but provides no ordering.
<
> locales but provides no ordering or character set classes.
Bruce Momjian [Tue, 15 Mar 2005 02:30:33 +0000 (02:30 +0000)]
Clean up win1252 documentation. Mention how we determine the number of
bytes/character for each encoding.
Bruce Momjian [Mon, 14 Mar 2005 20:15:09 +0000 (20:15 +0000)]
Issue free space notices to both the user and the server log file.
Tom Lane [Mon, 14 Mar 2005 18:57:33 +0000 (18:57 +0000)]
Make pg_dump emit a useful error message, instead of just dumping core,
if it finds a pg_rewrite entry for which there is no pg_class entry.
Per report from Andrew Slobodyanyk.
Bruce Momjian [Mon, 14 Mar 2005 18:31:25 +0000 (18:31 +0000)]
Add support for Win1252 encoding.
Roland Volkmann
Bruce Momjian [Mon, 14 Mar 2005 17:27:50 +0000 (17:27 +0000)]
Bump minor version numbers for 8.1 compared to 8.0.
Bruce Momjian [Mon, 14 Mar 2005 16:37:02 +0000 (16:37 +0000)]
Completed:
> * -Cache last known per-tuple offsets to speed long tuple access
Neil Conway [Mon, 14 Mar 2005 06:49:48 +0000 (06:49 +0000)]
Fix mistakes in SGML markup. From David Fetter.
Tom Lane [Mon, 14 Mar 2005 06:19:01 +0000 (06:19 +0000)]
Note that the -F and -R command line options only affect unaligned
output mode. This was already stated in other places in the psql
reference page, but not here.
Tom Lane [Mon, 14 Mar 2005 04:41:13 +0000 (04:41 +0000)]
Avoid O(N^2) overhead in repeated nocachegetattr calls when columns of
a tuple are being accessed via ExecEvalVar and the attcacheoff shortcut
isn't usable (due to nulls and/or varlena columns). To do this, cache
Datums extracted from a tuple in the associated TupleTableSlot.
Also some code cleanup in and around the TupleTable handling.
Atsushi Ogawa with some kibitzing by Tom Lane.
Bruce Momjian [Mon, 14 Mar 2005 03:59:22 +0000 (03:59 +0000)]
Document client-only encodings.
Bruce Momjian [Mon, 14 Mar 2005 03:07:25 +0000 (03:07 +0000)]
Fix typo on URL.
Bruce Momjian [Mon, 14 Mar 2005 03:00:26 +0000 (03:00 +0000)]
Add user:
> * Support triggers on columns (Greg Sabino Mullane)
Bruce Momjian [Mon, 14 Mar 2005 02:14:42 +0000 (02:14 +0000)]
Finalize character set documentation changes.
Neil Conway [Mon, 14 Mar 2005 00:19:37 +0000 (00:19 +0000)]
Allow ALTER FUNCTION to change a function's strictness, volatility, and
whether or not it is a security definer. Changing a function's strictness
is required by SQL2003, and the other capabilities make sense. Also, allow
an optional RESTRICT noise word to be specified, for SQL conformance.
Some trivial regression tests added and the documentation has been
updated.
Bruce Momjian [Mon, 14 Mar 2005 00:19:13 +0000 (00:19 +0000)]
Update comments for new encoding names.
Tom Lane [Sun, 13 Mar 2005 23:32:26 +0000 (23:32 +0000)]
Add missing identification comment, remove entirely inappropriate include
of postgres.h.
Tom Lane [Sun, 13 Mar 2005 23:27:38 +0000 (23:27 +0000)]
Add some missing #includes.
Bruce Momjian [Sun, 13 Mar 2005 22:04:29 +0000 (22:04 +0000)]
Increment all major version numbers in 8.0.X to force recompile of
client aplications so 7.4.X releases can be installed on the same
machine as 8.0.X.
Tom Lane [Sun, 13 Mar 2005 19:59:40 +0000 (19:59 +0000)]
Forgot that I had intended to replace division by masking in hash calculation.
Bruce Momjian [Sun, 13 Mar 2005 19:27:53 +0000 (19:27 +0000)]
Remove CENTER tag.
Neil Conway [Sun, 13 Mar 2005 09:36:31 +0000 (09:36 +0000)]
Make default_with_oids default to false -- user-created tables will now
no longer include OIDs, unless WITH OIDS is specified or the
default_with_oids configuration parameter is enabled. Update the docs
accordingly.
Bruce Momjian [Sun, 13 Mar 2005 05:31:04 +0000 (05:31 +0000)]
More ordering adjustments.
Neil Conway [Sun, 13 Mar 2005 05:19:26 +0000 (05:19 +0000)]
Update obsolete comment.
Bruce Momjian [Sun, 13 Mar 2005 05:16:33 +0000 (05:16 +0000)]
Fix markup.
Bruce Momjian [Sun, 13 Mar 2005 05:11:49 +0000 (05:11 +0000)]
More markup changes.
Bruce Momjian [Sun, 13 Mar 2005 04:35:06 +0000 (04:35 +0000)]
More cleanups.
Bruce Momjian [Sun, 13 Mar 2005 04:10:23 +0000 (04:10 +0000)]
More improvements.
Bruce Momjian [Sun, 13 Mar 2005 03:44:51 +0000 (03:44 +0000)]
More additions to the table.
Bruce Momjian [Sun, 13 Mar 2005 03:02:08 +0000 (03:02 +0000)]
Keep changing the markup until I like it. :-)
Bruce Momjian [Sun, 13 Mar 2005 02:54:34 +0000 (02:54 +0000)]
More table markup improvements.
Bruce Momjian [Sun, 13 Mar 2005 02:33:03 +0000 (02:33 +0000)]
More table markup fixes.
Bruce Momjian [Sun, 13 Mar 2005 02:20:50 +0000 (02:20 +0000)]
Rework "aliases" column for encodings.
Bruce Momjian [Sun, 13 Mar 2005 02:07:04 +0000 (02:07 +0000)]
Fix markup typo.
Bruce Momjian [Sun, 13 Mar 2005 02:02:44 +0000 (02:02 +0000)]
Add missing conversion documentation for certain encodings.
Bruce Momjian [Sun, 13 Mar 2005 01:30:59 +0000 (01:30 +0000)]
Reorder documented encodings to be alphabetical.
Remove warning about pre-7.2 LATIN5 usage.
Bruce Momjian [Sun, 13 Mar 2005 01:26:30 +0000 (01:26 +0000)]
Document aliases for our supported encodings.
Add a few encodings that were not documented.
Tom Lane [Sat, 12 Mar 2005 21:33:55 +0000 (21:33 +0000)]
When cloning template0 (or other fully-frozen databases), set the new
database's datallowconn and datfrozenxid to the current transaction ID
instead of copying the source database's values. This is OK because we
assume the source DB contains no normal transaction IDs whatsoever.
This keeps VACUUM from immediately starting to complain about unvacuumed
databases in the situation where we are more than 2 billion transactions
out from the XID stamp of template0. Per discussion with Milen Radev
(although his complaint turned out to be due to something else, but the
problem is real anyway).
Tom Lane [Sat, 12 Mar 2005 21:11:50 +0000 (21:11 +0000)]
Fix ALTER DATABASE RENAME to allow the operation if user is a superuser
who for some reason isn't marked usecreatedb. Per report from Alexander
Pravking. Also fix sloppy coding in have_createdb_privilege().
Tom Lane [Sat, 12 Mar 2005 20:25:06 +0000 (20:25 +0000)]
Adjust the API for aggregate function calls so that a C-coded function
can tell whether it is being used as an aggregate or not. This allows
such a function to avoid re-pallocing a pass-by-reference transition
value; normally it would be unsafe for a function to scribble on an input,
but in the aggregate case it's safe to reuse the old transition value.
Make int8inc() do this. This gets a useful improvement in the speed of
COUNT(*), at least on narrow tables (it seems to be swamped by I/O when
the table rows are wide). Per a discussion in early December with
Neil Conway. I also fixed int_aggregate.c to check this, thereby
turning it into something approaching a supportable technique instead
of being a crude hack.
Neil Conway [Sat, 12 Mar 2005 15:36:24 +0000 (15:36 +0000)]
Add pg_buffercache contrib module, from Mark Kirkwood.
Neil Conway [Sat, 12 Mar 2005 06:53:54 +0000 (06:53 +0000)]
Some builds (depends on crypto engine support?) of OpenSSL
0.9.7x have EVP_DigestFinal function which which clears all of
EVP_MD_CTX. This makes pgcrypto crash in functions which
re-use one digest context several times: hmac() and crypt()
with md5 algorithm.
Following patch fixes it by carring the digest info around
EVP_DigestFinal and re-initializing cipher.
Marko Kreen.
Bruce Momjian [Sat, 12 Mar 2005 06:28:17 +0000 (06:28 +0000)]
Documention all our supported encodings.
Bruce Momjian [Sat, 12 Mar 2005 05:41:38 +0000 (05:41 +0000)]
Done:
< o Allow COPY FROM ... CSV to interpret newlines and carriage
> o -Allow COPY FROM ... CSV to interpret newlines and carriage
Bruce Momjian [Sat, 12 Mar 2005 05:41:34 +0000 (05:41 +0000)]
Handle carriage returns and line feeds in COPY CSV mode.
Andrew Dunstan
Bruce Momjian [Sat, 12 Mar 2005 05:25:49 +0000 (05:25 +0000)]
Done:
* -Add a warning when the free space map is too small
Bruce Momjian [Sat, 12 Mar 2005 05:21:52 +0000 (05:21 +0000)]
Add warning about the need to increase "max_fsm_relations" and
"max_fsm_relations" for vacuums. Also improve VACUUM VERBOSE final
message text.
Ron Mayer
Bruce Momjian [Sat, 12 Mar 2005 04:00:56 +0000 (04:00 +0000)]
Fix snprintf() to properly handle precision specification for %f.
Tom Lane [Sat, 12 Mar 2005 01:54:44 +0000 (01:54 +0000)]
Fix problem with infinite recursion between write_syslogger_file and
elog if the former has trouble writing its file. Code review for
Magnus' patch to redirect stderr to syslog on Windows (Bruce's version
seems right, but did some minor prettification).
Backpatch both changes to 8.0 branch.
Bruce Momjian [Fri, 11 Mar 2005 21:46:54 +0000 (21:46 +0000)]
Here's the patch to fix a lot of markup errors in the HTML FAQs. Doesn't
change content (at least not supposed to).
Magnus Hagander
Bruce Momjian [Fri, 11 Mar 2005 19:13:43 +0000 (19:13 +0000)]
Add fprintf() custom version to libpgport.
Document use of macros for pg_printf functions.
Bump major versions of all interfaces to handle movement of get_progname
from libpq to libpgport in 8.0, and probably other libpgport changes in 8.1.