Rethink pg_dump's handling of object ACLs.
authorTom Lane <[email protected]>
Mon, 6 Dec 2021 17:39:45 +0000 (12:39 -0500)
committerTom Lane <[email protected]>
Mon, 6 Dec 2021 17:39:45 +0000 (12:39 -0500)
commit0c9d84427f441602425b0e18be5cfe751d1d8ebe
tree0413d147aa918d556f081a4720258d8cf0dba6d7
parent5209c0ba0bfd16f23e38f707e487c0626e70564c
Rethink pg_dump's handling of object ACLs.

Throw away most of the existing logic for this, as it was very
inefficient thanks to expensive sub-selects executed to collect
ACL data that we very possibly would have no interest in dumping.
Reduce the ACL handling in the initial per-object-type queries
to be just collection of the catalog ACL fields, as it was
originally.  Fetch pg_init_privs data separately in a single
scan of that catalog, and do the merging calculations on the
client side.  Remove the separate code path used for pre-9.6
source servers; there is no good reason to treat them differently
from newer servers that happen to have empty pg_init_privs.

Discussion: https://postgr.es/m/2273648.1634764485@sss.pgh.pa.us
Discussion: https://postgr.es/m/7d7eb6128f40401d81b3b7a898b6b4de@W2012-02.nidsa.loc
src/bin/pg_dump/dumputils.c
src/bin/pg_dump/dumputils.h
src/bin/pg_dump/pg_dump.c
src/bin/pg_dump/pg_dump.h
src/bin/pg_dump/pg_dumpall.c
src/fe_utils/string_utils.c
src/include/fe_utils/string_utils.h