Consistently truncate non-key suffix columns.
authorPeter Geoghegan <[email protected]>
Mon, 30 Mar 2020 19:03:59 +0000 (12:03 -0700)
committerPeter Geoghegan <[email protected]>
Mon, 30 Mar 2020 19:03:59 +0000 (12:03 -0700)
commit4b42a89938ac9d2ec06e9d831356407040e9094c
tree7ac5ec10fa2fd106def3d5fd4ac2d183253a44ee
parent911e70207703799605f5a0e8aad9f06cff067c63
Consistently truncate non-key suffix columns.

INCLUDE indexes failed to have their non-key attributes physically
truncated away in certain rare cases.  This led to physically larger
pivot tuples that contained useless non-key attribute values.  The
impact on users should be negligible, but this is still clearly a
regression (Postgres 11 supports INCLUDE indexes, and yet was not
affected).

The bug appeared in commit dd299df8, which introduced "true" suffix
truncation of key attributes.

Discussion: https://postgr.es/m/CAH2-Wz=E8pkV9ivRSFHtv812H5ckf8s1-yhx61_WrJbKccGcrQ@mail.gmail.com
Backpatch: 12-, where "true" suffix truncation was introduced.
src/backend/access/nbtree/nbtutils.c