Refactor nbtree high key truncation.
authorPeter Geoghegan <[email protected]>
Mon, 30 Mar 2020 22:52:39 +0000 (15:52 -0700)
committerPeter Geoghegan <[email protected]>
Mon, 30 Mar 2020 22:52:39 +0000 (15:52 -0700)
commit7c2dbc691c3e19b7d33c78f6c8aacc6e0cab510b
treed1bb48191eb8bcfc3192ac3ab41073506111953f
parentd4b34f60c54904bb3647911dfd9d79d8a4fab430
Refactor nbtree high key truncation.

Simplify _bt_truncate(), the routine that generates truncated leaf page
high keys.  Remove a micro-optimization that avoided a second palloc0()
call (this was used when a heap TID was needed in the final pivot tuple,
though only when the index happened to not be an INCLUDE index).

Removing this dubious micro-optimization allows _bt_truncate() to use
the index_truncate_tuple() indextuple.c utility routine in all cases.
This was already the common case.

This commit is a HEAD-only follow up to bugfix commit 4b42a899.
src/backend/access/nbtree/nbtutils.c