Add --buffer-usage-limit option to vacuumdb
authorDavid Rowley <[email protected]>
Fri, 7 Apr 2023 00:47:10 +0000 (12:47 +1200)
committerDavid Rowley <[email protected]>
Fri, 7 Apr 2023 00:47:10 +0000 (12:47 +1200)
commitae78cae3be627213528f2e08eb976d6906d754de
tree2a26745127fc1fa06d9890d6406a1280ad523705
parent00d1e02be24987180115e371abaeb84738257ae2
Add --buffer-usage-limit option to vacuumdb

1cbbee033 added BUFFER_USAGE_LIMIT to the VACUUM and ANALYZE commands, so
here we permit that option to be specified in vacuumdb.

In passing, adjust the documents for vacuum_buffer_usage_limit and the
BUFFER_USAGE_LIMIT VACUUM option to mention "kB" rather than "KB".  Do the
same for the ERROR message in ExecVacuum() and
check_vacuum_buffer_usage_limit().  Without that we might tell a user that
the valid minimum value is 128 KB only to reject that because we accept
only "kB" and not "KB".

Also, add a small reminder comment in vacuum.h to try to trigger the
memory of anyone adding new fields to VacuumParams that they might want to
consider if vacuumdb needs to grow a new option too.

Author: Melanie Plageman
Reviewed-by: Justin Pryzby
Reviewed-by: David Rowley
Discussion: https://postgr.es/m/[email protected]
doc/src/sgml/config.sgml
doc/src/sgml/ref/vacuumdb.sgml
src/backend/commands/vacuum.c
src/bin/scripts/vacuumdb.c
src/include/commands/vacuum.h
src/test/regress/expected/vacuum.out