Fix pg_dump for disabled triggers on partitioned tables
authorAlvaro Herrera <[email protected]>
Fri, 16 Jul 2021 21:29:22 +0000 (17:29 -0400)
committerAlvaro Herrera <[email protected]>
Fri, 16 Jul 2021 21:29:22 +0000 (17:29 -0400)
commitf0e21f2f61675f4e56ae53d32ea54d587a7c2257
tree21bd25ee91ef7526d91037a3a5824b3b51faa71b
parentdf80fa2ee50478391445cef03e42c1b3d64fccca
Fix pg_dump for disabled triggers on partitioned tables

pg_dump failed to preserve the 'enabled' flag (which can be not only
disabled, but also REPLICA or ALWAYS) for partitions which had it
changed from their respective parents.  Attempt to handle that by
including a definition for such triggers in the dump, but replace the
standard CREATE TRIGGER line with an ALTER TRIGGER line.

Backpatch to 11, where these triggers can exist.  In branches 11 and 12,
pick up a few test lines from commit b9b408c48724 to verify that
pg_upgrade is okay with these arrangements.

Co-authored-by: Justin Pryzby <[email protected]>
Co-authored-by: Álvaro Herrera <[email protected]>
Discussion: https://postgr.es/m/20200930223450[email protected]
src/bin/pg_dump/pg_dump.c
src/bin/pg_dump/pg_dump.h
src/bin/pg_dump/t/002_pg_dump.pl
src/test/regress/expected/sanity_check.out
src/test/regress/expected/triggers.out
src/test/regress/sql/triggers.sql