From 32fbe0239b03d868744758d5809eaf74f19c924d Mon Sep 17 00:00:00 2001 From: David Rowley Date: Mon, 3 Apr 2023 19:19:45 +1200 Subject: [PATCH] Only make buffer strategy for vacuum when it's likely needed VACUUM FULL and VACUUM ONLY_DATABASE_STATS will not use the vacuum strategy ring created in vacuum(), so don't waste effort making it in those cases. There are other conceivable cases where the buffer strategy also won't be used, but those are probably less common and not worth troubling over too much. For example VACUUM (PROCESS_MAIN false, PROCESS_TOAST false). There are other cases too, but many of these are only discovered once inside vacuum_rel(). Author: Melanie Plageman Reviewed-by: David Rowley Discussion: https://postgr.es/m/CAAKRu_ZLRuzkM3zKogiZAz2hUony37yLY4aaLb8fPf8fgqs5Og@mail.gmail.com --- src/backend/commands/vacuum.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/backend/commands/vacuum.c b/src/backend/commands/vacuum.c index 96088a754c..1c3437336d 100644 --- a/src/backend/commands/vacuum.c +++ b/src/backend/commands/vacuum.c @@ -393,7 +393,9 @@ vacuum(List *relations, VacuumParams *params, * If caller didn't give us a buffer strategy object, make one in the * cross-transaction memory context. */ - if (bstrategy == NULL) + if (bstrategy == NULL && + !(params->options & VACOPT_ONLY_DATABASE_STATS || + params->options & VACOPT_FULL)) { MemoryContext old_context = MemoryContextSwitchTo(vac_context); -- 2.30.2