From ebd551f586a801dee426e49ba72fb213e8013890 Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Fri, 3 Mar 2023 12:52:04 -0500 Subject: [PATCH] Update some incorrect comments about xlog records. The comments claim that certain pieces of data are part of the main WAL record data when in reality they are part of the data for block 0. Repair. Bertrand Drouvot, reviewed by Amit Kapila. Originally reported by me. Discussion: http://postgr.es/m/80db7836-4415-d54a-64c3-66b88b1430e7@gmail.com --- src/include/access/gistxlog.h | 4 +--- src/include/access/heapam_xlog.h | 5 +++-- src/include/access/nbtxlog.h | 10 +++++++--- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/include/access/gistxlog.h b/src/include/access/gistxlog.h index 09f9b0f8c6..2ce9366277 100644 --- a/src/include/access/gistxlog.h +++ b/src/include/access/gistxlog.h @@ -52,9 +52,7 @@ typedef struct gistxlogDelete TransactionId snapshotConflictHorizon; uint16 ntodelete; /* number of deleted offsets */ - /* - * In payload of blk 0 : todelete OffsetNumbers - */ + /* TODELETE OFFSET NUMBER ARRAY FOLLOWS */ } gistxlogDelete; #define SizeOfGistxlogDelete (offsetof(gistxlogDelete, ntodelete) + sizeof(uint16)) diff --git a/src/include/access/heapam_xlog.h b/src/include/access/heapam_xlog.h index 8cb0d8da19..a2c67d1cd3 100644 --- a/src/include/access/heapam_xlog.h +++ b/src/include/access/heapam_xlog.h @@ -345,8 +345,9 @@ typedef struct xl_heap_freeze_page TransactionId snapshotConflictHorizon; uint16 nplans; - /* FREEZE PLANS FOLLOW */ - /* OFFSET NUMBER ARRAY FOLLOWS */ + /* + * In payload of blk 0 : FREEZE PLANS and OFFSET NUMBER ARRAY + */ } xl_heap_freeze_page; #define SizeOfHeapFreezePage (offsetof(xl_heap_freeze_page, nplans) + sizeof(uint16)) diff --git a/src/include/access/nbtxlog.h b/src/include/access/nbtxlog.h index edd1333d9b..7dd67257f2 100644 --- a/src/include/access/nbtxlog.h +++ b/src/include/access/nbtxlog.h @@ -236,9 +236,13 @@ typedef struct xl_btree_delete uint16 ndeleted; uint16 nupdated; - /* DELETED TARGET OFFSET NUMBERS FOLLOW */ - /* UPDATED TARGET OFFSET NUMBERS FOLLOW */ - /* UPDATED TUPLES METADATA (xl_btree_update) ARRAY FOLLOWS */ + /*---- + * In payload of blk 0 : + * - DELETED TARGET OFFSET NUMBERS + * - UPDATED TARGET OFFSET NUMBERS + * - UPDATED TUPLES METADATA (xl_btree_update) ARRAY + *---- + */ } xl_btree_delete; #define SizeOfBtreeDelete (offsetof(xl_btree_delete, nupdated) + sizeof(uint16)) -- 2.30.2