Fix assertion failure when running pgbench -s.
authorFujii Masao <[email protected]>
Thu, 7 Nov 2019 07:31:36 +0000 (16:31 +0900)
committerFujii Masao <[email protected]>
Thu, 7 Nov 2019 07:33:06 +0000 (16:33 +0900)
commit127ad57f5d44403c5641fa9297886e80c41ec409
treecb2c4f858af6312f8fa50624296e34fbe74d0520
parenta5b95016af918c0b147bb21bb52357b45f0376e9
Fix assertion failure when running pgbench -s.

If there is the WAL page that the continuation WAL record just fits within
(i.e., the continuation record ends just at the end of the page) and
the LSN in such page is specified with -s option, previously pg_waldump
caused an assertion failure. The cause of this assertion failure was that
XLogFindNextRecord() that pg_waldump -s calls mistakenly handled
such special WAL page.

This commit changes XLogFindNextRecord() so that it can handle
such WAL page correctly.

Back-patch to all supported versions.

Author: Andrey Lepikhov
Reviewed-by: Fujii Masao, Michael Paquier
Discussion: https://postgr.es/m/99303554-5dd5-06e6-f943-b3005ccd6edd@postgrespro.ru
src/backend/access/transam/xlogreader.c