Prevent deadlock in ginRedoDeletePage()
authorAlexander Korotkov <[email protected]>
Thu, 13 Dec 2018 03:12:25 +0000 (06:12 +0300)
committerAlexander Korotkov <[email protected]>
Thu, 13 Dec 2018 03:15:23 +0000 (06:15 +0300)
commit225b5c9c480fa90d4734ce4a8d1a4b46ac5e826e
tree9af9bc057fef0e3c31f9b5fda2b0aaee05f5defd
parent9aa94d8536f81168b6de3744c1fb4a173af1cefe
Prevent deadlock in ginRedoDeletePage()

On standby ginRedoDeletePage() can work concurrently with read-only queries.
Those queries can traverse posting tree in two ways.
1) Using rightlinks by ginStepRight(), which locks the next page before
   unlocking its left sibling.
2) Using downlinks by ginFindLeafPage(), which locks at most one page at time.

Original lock order was: page, parent, left sibling.  That lock order can
deadlock with ginStepRight().  In order to prevent deadlock this commit changes
lock order to: left sibling, page, parent.  Note, that position of parent in
locking order seems insignificant, because we only lock one page at time while
traversing downlinks.

Reported-by: Chen Huajun
Diagnosed-by: Chen Huajun, Peter Geoghegan, Andrey Borodin
Discussion: https://postgr.es/m/31a702a.14dd.166c1366ac1.Coremail.chjischj%40163.com
Author: Alexander Korotkov
Backpatch-through: 9.4
src/backend/access/gin/ginxlog.c