Use printf's %m format instead of strerror(errno) in more places
authorMichael Paquier <[email protected]>
Tue, 12 Mar 2024 01:02:54 +0000 (10:02 +0900)
committerMichael Paquier <[email protected]>
Tue, 12 Mar 2024 01:02:54 +0000 (10:02 +0900)
commit2c8118ee5d980e11f73683fcda2329c323aa381e
tree7527eb2a94bc9cc8821ff9afba62e03918dff351
parent3045324214467dd3f0bef31f6f33562b9eb93aa3
Use printf's %m format instead of strerror(errno) in more places

Most callers of strerror() are removed from the backend code.  The
remaining callers require special handling with a saved errno from a
previous system call.  The frontend code still needs strerror() where
error states need to be handled outside of fprintf.

Note that pg_regress is not changed to use %m as the TAP output may
clobber errno, since those functions call fprintf() and friends before
evaluating the format string.

Support for %m in src/port/snprintf.c has been added in d6c55de1f99a,
hence all the stable branches currently supported include it.

Author: Dagfinn Ilmari Mannsåker
Discussion: https://postgr.es/m/[email protected]
24 files changed:
src/backend/postmaster/postmaster.c
src/backend/postmaster/syslogger.c
src/backend/utils/misc/guc.c
src/bin/initdb/findtimezone.c
src/bin/pg_ctl/pg_ctl.c
src/bin/pg_dump/compress_gzip.c
src/bin/pg_dump/compress_none.c
src/bin/pg_upgrade/check.c
src/bin/pg_upgrade/controldata.c
src/bin/pg_upgrade/exec.c
src/bin/pg_upgrade/file.c
src/bin/pg_upgrade/function.c
src/bin/pg_upgrade/option.c
src/bin/pg_upgrade/parallel.c
src/bin/pg_upgrade/pg_upgrade.c
src/bin/pg_upgrade/relfilenumber.c
src/bin/pg_upgrade/tablespace.c
src/bin/pg_upgrade/version.c
src/common/psprintf.c
src/interfaces/ecpg/preproc/ecpg.c
src/port/path.c
src/test/isolation/isolationtester.c
src/test/modules/libpq_pipeline/libpq_pipeline.c
src/tools/ifaddrs/test_ifaddrs.c