pg_controldata: Fix possible errors on corrupted pg_control
authorAlexander Korotkov <[email protected]>
Tue, 4 Feb 2025 22:15:17 +0000 (00:15 +0200)
committerAlexander Korotkov <[email protected]>
Tue, 4 Feb 2025 22:46:06 +0000 (00:46 +0200)
commitc24311c1fed18ebdf0e64f31a8cd86cd3232657b
tree3309bfc8d1ac7fb87d3b2063a9fd3bb22bda76b7
parentd6ea82f5da181eb4278595d7dca601568deeed5e
pg_controldata: Fix possible errors on corrupted pg_control

Protect against malformed timestamps.  Also protect against negative WalSegSz
as it triggers division by zero:

((0x100000000UL) / (WalSegSz)) can turn into zero in

XLogFileName(xlogfilename, ControlFile->checkPointCopy.ThisTimeLineID,
             segno, WalSegSz);

because if WalSegSz is -1 then by arithmetic rules in C we get
0x100000000UL / 0xFFFFFFFFFFFFFFFFUL == 0.

Author: Ilyasov Ian <[email protected]>
Author: Anton Voloshin <[email protected]>
Backpatch-through: 13
src/bin/pg_controldata/pg_controldata.c