Fix privilege checks for pg_prewarm() on indexes.
authorNathan Bossart <[email protected]>
Fri, 17 Oct 2025 16:36:50 +0000 (11:36 -0500)
committerNathan Bossart <[email protected]>
Fri, 17 Oct 2025 16:36:50 +0000 (11:36 -0500)
commitf146eb45cb1ae3e6fb0e1684e33ebaba21c8726d
tree2a9839ac44ff00e6c629fcbce3eebee7f08c2963
parent56cd332f80b260ebc1eef825d4b5acd6d6a54310
Fix privilege checks for pg_prewarm() on indexes.

pg_prewarm() currently checks for SELECT privileges on the target
relation.  However, indexes do not have access rights of their own,
so a role may be denied permission to prewarm an index despite
having the SELECT privilege on its parent table.  This commit fixes
this by locking the parent table before the index (to avoid
deadlocks) and checking for SELECT on the parent table.  Note that
the code is largely borrowed from
amcheck_lock_relation_and_check().

An obvious downside of this change is the extra AccessShareLock on
the parent table during prewarming, but that isn't expected to
cause too much trouble in practice.

Author: Ayush Vatsa <[email protected]>
Co-authored-by: Nathan Bossart <[email protected]>
Reviewed-by: Tom Lane <[email protected]>
Reviewed-by: Jeff Davis <[email protected]>
Discussion: https://postgr.es/m/CACX%2BKaMz2ZoOojh0nQ6QNBYx8Ak1Dkoko%3DD4FSb80BYW%2Bo8CHQ%40mail.gmail.com
Backpatch-through: 13
contrib/pg_prewarm/pg_prewarm.c