Skip foreign tablespaces when running pg_checksums/pg_verify_checksums
authorMichael Paquier <[email protected]>
Thu, 27 Feb 2020 06:31:48 +0000 (15:31 +0900)
committerMichael Paquier <[email protected]>
Thu, 27 Feb 2020 06:31:48 +0000 (15:31 +0900)
commitf6e8e8b3809b58a0ab6c5369e8baa1fd9b96e73e
tree52f3c6bfdf1e4262a7188e641c243e6cdfc85ea8
parent943affb3d1db38ba0960ee9a0666ea2598b78f1f
Skip foreign tablespaces when running pg_checksums/pg_verify_checksums

Attempting to use pg_checksums (pg_verify_checksums in 11) on a data
folder which includes tablespace paths used across multiple major
versions would cause pg_checksums to scan all directories present in
pg_tblspc, and not only marked with TABLESPACE_VERSION_DIRECTORY.  This
could lead to failures when for example running sanity checks on an
upgraded instance with --check.  Even worse, it was possible to rewrite
on-disk pages with --enable for a cluster potentially online.

This commit makes pg_checksums skip any directories not named
TABLESPACE_VERSION_DIRECTORY, similarly to what is done for base
backups.

Reported-by: Michael Banck
Author: Michael Banck, Bernd Helmle
Discussion: https://postgr.es/m/62031974fd8e941dd8351fbc8c7eff60d59c5338[email protected]
backpatch-through: 11
src/bin/pg_checksums/pg_checksums.c
src/bin/pg_checksums/t/002_actions.pl