> Rod Taylor <[email protected]> writes:

> > It seems that readline() on my system (FreeBSD 4.8) isn't declared to
> > take the prompt as a const.  Thus, remove const from gets_interactive()
> > to remove the warning.
>
> I think it would be a lot cleaner to just put a cast to char * into the
> readline call (with a note about why).

Ok.. that works.

I must say it's a little strange being able to take a constant and say
its no longer constant anymore -- but I suppose it's no different than
defining then undefining pre-processor constants.

Rod Taylor <[email protected]>

diff --git a/src/bin/psql/input.c b/src/bin/psql/input.c
index cb0cc6776591d0a8d269f7eae962cfe5e51bae01..26fe7659e2abedc3048640e7546bdfc9faf98d27 100644 (file)
--- a/src/bin/psql/input.c
+++ b/src/bin/psql/input.c
@@ -3,7 +3,7 @@
  *
  * Copyright 2000 by PostgreSQL Global Development Group
  *
- * $Header: /cvsroot/pgsql/src/bin/psql/input.c,v 1.24 2003/07/23 08:47:39 petere Exp $
+ * $Header: /cvsroot/pgsql/src/bin/psql/input.c,v 1.25 2003/07/25 19:27:06 momjian Exp $
  */
 #include "postgres_fe.h"
 #include "input.h"
@@ -86,7 +86,8 @@ gets_interactive(const char *prompt)
    static char *prev_hist = NULL;
 
    if (useReadline)
-       s = readline(prompt);
+       /* On some platforms, readline is declared as readline(char *) */
+       s = readline((char *) prompt);
    else
        s = gets_basic(prompt);