Avoiding:

cc1: warnings being treated as errors
datum.c: In function `DatumGetSize':
datum.c:57: warning: unsigned value >= 0 is always 1
gmake[3]: *** [datum.o] Error 1

There was:
    if (byVal) {
        if (len >= 0 && len <= sizeof(Datum)) {

but len has type Size (unsigned int) and so now there is:
    if (byVal) {
        if (len <= sizeof(Datum)) {
            size = len;
        } else {
            elog(WARN,
                 "datumGetSize: Error: type=%ld, byVaL with len=%d",
                 (long) type, len);
        }
    } else { /*  not byValue */

diff --git a/src/backend/utils/adt/datum.c b/src/backend/utils/adt/datum.c
index 11efd89e7a92c3e5ac77696fbdb07e5bfb47b2ba..c9a49fb5c2822a3e040be9a42ddd5b6629fbfe51 100644 (file)
--- a/src/backend/utils/adt/datum.c
+++ b/src/backend/utils/adt/datum.c
@@ -6,7 +6,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/utils/adt/datum.c,v 1.3 1996/11/08 05:59:41 momjian Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/utils/adt/datum.c,v 1.3.2.1 1996/12/14 07:54:22 vadim Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -54,7 +54,7 @@ datumGetSize(Datum value, Oid type, bool byVal, Size len)
     Size size = 0;
     
     if (byVal) {
-   if (len >= 0 && len <= sizeof(Datum)) {
+   if (len <= sizeof(Datum)) {
        size = len;
    } else {
        elog(WARN,