Testing docs #2665
Merged
Testing docs #2665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthtrevino
approved these changes
Jul 11, 2020
|
|
||
| ### Libraries | ||
|
|
||
| #### With create-react-app |
There was a problem hiding this comment.
I think you can actually delete this section on using create-react-app now - the libraries ship with CJS as the default module format
There was a problem hiding this comment.
Oh! I think I'm trying to push the same changes after you and that's why it's getting rejected!
Thanks for the speedy review and tidies for the spellcheck ignore.
There was a problem hiding this comment.
no problem, thank you for the update!
|
The build failure looks like it's throwing on the |
This was referenced Mar 15, 2021
darthtrevino
added a commit
that referenced
this pull request
Feb 3, 2022
* docs: spelling updates, remove CRA instructions * docs: add DevTools to spelling * add redux devtools config info * re-order + add JSDOM related testing info Co-authored-by: Chris Trevino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit Project Documentation for Testing + Troubleshooting
Description
Rationale
I just spent a little too long getting this to work, looking up the DataTransfer object, reading the React DND source code, and wondering if my problem was that there wasn't a DragEvent in JSDOM.
Turns out it was simple... if you do it right 😝