Skip to content

Correct InternalAffairs/ProcessedSourceBufferName cop #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Feb 22, 2023

The CI running RuboCop in Edge is failed. We correct offense for InternalAffairs/ProcessedSourceBufferName cop. https://github.com/rubocop/rubocop-rspec/actions/runs/4241877273/jobs/7372656638

Follow up: rubocop/rubocop#11606

lib/rubocop/cop/rspec/file_path.rb:168:45: C: [Correctable] InternalAffairs/ProcessedSourceBufferName: Use file_path instead.
          File.expand_path(processed_source.buffer.name)
                                            ^^^^^^^^^^^

277 files inspected, 1 offense detected, 1 offense autocorrectable
Error: Process completed with exit code 1.

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

The CI running RuboCop in Edge is failed. We correct offense for `InternalAffairs/ProcessedSourceBufferName` cop.
https://github.com/rubocop/rubocop-rspec/actions/runs/4241877273/jobs/7372656638

Follow up: rubocop/rubocop#11606

```
lib/rubocop/cop/rspec/file_path.rb:168:45: C: [Correctable] InternalAffairs/ProcessedSourceBufferName: Use file_path instead.
          File.expand_path(processed_source.buffer.name)
                                            ^^^^^^^^^^^

277 files inspected, 1 offense detected, 1 offense autocorrectable
Error: Process completed with exit code 1.
```
@ydah ydah marked this pull request as ready for review February 22, 2023 10:50
@pirj pirj merged commit f6e995c into rubocop:master Feb 22, 2023
@pirj
Copy link
Member

pirj commented Feb 22, 2023

Thank you!

@ydah ydah deleted the fix-ProcessedSourceBufferName branch February 22, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants