Skip to content

simplify encoding logic: no more chomping required #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2020
Merged

simplify encoding logic: no more chomping required #362

merged 1 commit into from
Jul 6, 2020

Conversation

pvdb
Copy link

@pvdb pvdb commented Jul 6, 2020

As per #326 (comment)

I think https://ruby-doc.org/stdlib/libdoc/base64/rdoc/Base64.html#method-i-strict_encode64 would make this even more simple and not require calling #chomp

All done now... test still pass! 👍

@pvdb pvdb mentioned this pull request Jul 6, 2020
Merged
HarlemSquirrel
HarlemSquirrel approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HarlemSquirrel HarlemSquirrel merged commit e6b1312 into ruby-ldap:master Jul 6, 2020
@pvdb pvdb deleted the use_strict_encode64 branch July 6, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HarlemSquirrel HarlemSquirrel HarlemSquirrel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pvdb @HarlemSquirrel