Add ability to initialize experiments #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrehjr
reviewed
Mar 4, 2022
| @@ -24,3 +26,16 @@ | |||
| <p class="intro">No experiments have started yet, you need to define them in your code and introduce them to your users.</p> | |||
| <p class="intro">Check out the <a href='https://github.com/splitrb/split#readme'>Readme</a> for more help getting started.</p> | |||
| <% end %> | |||
|
|
|||
| <div class="dashboard-controls dashboard-controls-bottom"> | |||
There was a problem hiding this comment.
Maybe this can be hidden from the UI if @unintialized_experiments is empty?
There was a problem hiding this comment.
Will address this later, not an issue for merging this right now.
|
Thanks for the PR @robin-phung 🙌 🎉 sorry It took me so long to take a look. |
Oops sorry didn't notice the reply! Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
When using the start_manually experiment configuration, an experiment cannot be started unless ab_test is called so that the experiment is initialized ~ added to the dashboard.
How does this solve it?